Integrate with Kauri API :: GetRawTransactions #46

zanuka · 2018-06-20T13:12:06Z

This wires up the api service, data service, model and wallet component to get raw tx data for supplied wallet addresses of selected currency.

Note: To test this, you'll need the Kauri API running. Follow the directions here

…es :: .editorconfig

red010b37 · 2018-06-20T22:35:33Z

packages/kauri-wallet/src/app/api.service.ts

+    constructor(private http: HttpClient) {}
+
+    getRawTransactions(addresses: any[]) {
+


we should always type the arrays - so string[] avoid using any where ever possible

@red010b37 updated 🌮

red010b37 · 2018-06-20T22:36:18Z

packages/kauri-wallet/src/app/api-sample/api-sample.component.ts

+  styleUrls: ['./api-sample.component.css']
+})
+export class ApiSampleComponent {
+  addresses = []


we should always strongly type the arrays - so addresses = string[]

red010b37

Press the wroing btn

zanuka · 2018-06-21T20:39:02Z

@red010b37 can you test this branch and let me know if you have any further suggestions? I made some additional updates last night

matt-auckland · 2018-06-25T13:49:27Z

Still not working for me, I'm getting CORS errors.
Do we need to update the package GoLang is building to allow CORS?

zanuka · 2018-06-25T19:58:31Z

@ro-savage Yeah it's setup to only accept wallet addresses, not txids. So in Postman, the request body would look like this:

{"transactions": [
    {"currency":  "NAV", "addresses": ["NW7uXr4ZAeJKigMGnKbSLfCBQY59cH1T8G", "NUDke42E3fwLqaBbBFRyVSTETuhWAi7ugk"]}
]}

And when testing from this branch, you would select NAV from the dropdown and then enter 2 NAV wallet addresses in the inputs. The logic in this PR will build out the proper request body (above) and POST it to the Kauri API running locally. The response will then contain all of the raw transaction data for each address.

ro-savage · 2018-06-25T20:03:37Z

packages/kauri-wallet/src/app/wallet/wallet.component.ts

+
+  onGetTransactions(currency: string, addresses: string[]) {
+
+    const apiModel: ApiModel = {} as ApiModel;


I thought the as syntax was for overwriting the intefered type.
E.g. Type Assertions

However, it seems to be in a lot of places.

Would just const apiModel = {} as ApiModel; work?

Or

const apiModel: ApiModel = { currency, addresses, };

To take it a step further, does this work?

wallet.component.html

onGetTransactions(transactionsReq: ApiModel) { this._apiService.getRawTransactions(transactionsReq); }

wallet.component.html

<button mat-raised-button (click)="onGetTransactions({ currency: currency.value, addresses: [addressOne.value, addressTwo.value]})">Get Transactions</button>

I am not sure if/how angular/typescript handle type errors in a template?

As discussed we should do as ApiModel for consistency.
const apiModel: ApiModel = {} as ApiModel;

ro-savage · 2018-06-25T20:10:10Z

packages/kauri-wallet/src/app/wallet/wallet.component.html

+
+  <br>
+
+  <input matInput placeholder="Enter Address" type="text" #addressTwo>


We still have a few matInput, mat-raised etc in the template files

ro-savage · 2018-06-26T09:55:54Z

@zanuka - Let us know when you are ready for a review (e.g. you think its completed)

…aw-transactions

zanuka · 2018-06-26T11:41:29Z

the following spec tests have been added for parsed response data:

parseRawTransaction
currency
data should have currency
currency should be NAV
parseAddressItem()
should have correct address
parseTransactions()
transaction 1 test
should have correct txid
should have correct rawtxt
should have correct verbose
transaction 2 test
should have correct txid
should have correct rawtxt
should have verbose
parseVerbose()
should have no anon dest
should have correct blockhash
should have correct blocktime
should have correct confirmations
should have correct hash
should have correct height
should have correct hex
should have correct locktime
should have correct size
should have correct time
should have correct txid
should have correct version
parseVinData()
should have a scriptSig object
should have correct sequence
should have correct txid
should have correct vout
parseScriptSigData()
should have asm
should have hex
parseVoutData()
should have correct value for n
should have scriptPubKey object
should have correct value for value
should have correct value for valueSat
scriptPubKeyData()
should have addresses
should have correct asm
should have correct hex
should have correct reqSigs
should have correct type

zanuka · 2018-06-26T11:51:22Z

@ro-savage it's ready for review. I'm happy with it at this point. From this pattern we can expand/adapt functionality. Just need to get it passing the lighthouse gauntlet 🔨

codecov-io · 2018-06-26T14:09:29Z

Codecov Report

❗ No coverage uploaded for pull request base (master@f3556b0). Click here to learn what that means.
The diff coverage is 84.95%.

@@            Coverage Diff            @@
##             master      #46   +/-   ##
=========================================
  Coverage          ?   84.07%           
=========================================
  Files             ?       13           
  Lines             ?      157           
  Branches          ?        0           
=========================================
  Hits              ?      132           
  Misses            ?       25           
  Partials          ?        0

Impacted Files	Coverage Δ
...ers/sw-update-prompt/sw-update-prompt.component.ts	`69.23% <ø> (ø)`
...kages/kauri-wallet/src/environments/environment.ts	`100% <ø> (ø)`
...ri-wallet/src/app/services/api/api.service.stub.ts	`100% <100%> (ø)`
...app/services/api/parsers/raw-transaction-parser.ts	`100% <100%> (ø)`
...kauri-wallet/src/app/services/data/data.service.ts	`100% <100%> (ø)`
packages/kauri-wallet/src/app/app.component.ts	`100% <100%> (ø)`
...translation-sample/translation-sample.component.ts	`100% <100%> (ø)`
...s/kauri-wallet/src/app/services/api/api.service.ts	`38.09% <38.09%> (ø)`
...es/kauri-wallet/src/app/wallet/wallet.component.ts	`71.42% <71.42%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3556b0...3cb5d1d. Read the comment docs.

ro-savage · 2018-06-26T21:25:49Z

packages/kauri-wallet/src/app/services/api/parsers/raw-transaction-parser.ts

+  txAddress.address = item['address'];
+  txAddress.transactions = [];
+
+  item['transactions'].forEach((tx) => {


Throws on item.transactions = null which is the default result if only one item is requested.

Maybe should add a test for null/undefined, and ensure we handle it.

@ro-savage sounds good, will add

ro-savage · 2018-06-26T22:33:36Z

packages/kauri-wallet/tslint.json

@@ -28,8 +28,7 @@
    "interface-over-type-literal": true,
    "label-position": true,
    "max-line-length": [
-      true,
-      140
+      false
    ],
    "member-access": false,
    "member-ordering": [


On line 73 can we change :

"no-unused-expressions": true,
to
"no-unused-expressions": ["error", { "allowShortCircuit": true, "allowTernary": true }],

So we can do short cuts like data.transactions && data.transactions.forEach()

great suggestion, just updated 🔍

ro-savage

Happy with this as is.

Awesome work getting it started and getting us a great base to learn from.

We'll make whatever changes we need as we add more real world use cases.

zanuka · 2018-06-26T22:40:45Z

@ro-savage sounds good, thanks for the review guys. Agreed, it's a good base and am looking forward to the next phase of feature adds.

updates made, team approved

adds api service :: get raw transactions from supplied wallet address…

e14acbd

…es :: .editorconfig

zanuka requested review from red010b37, ro-savage and matt-auckland June 20, 2018 13:12

red010b37 approved these changes Jun 20, 2018

View reviewed changes

red010b37 previously requested changes Jun 20, 2018

View reviewed changes

zanuka added 5 commits June 21, 2018 12:16

adds model :: outputs result :: improve pattern

6bfa0ab

adds data service

c8e87a1

fixes lint errors :: for reals

caecae4

adds bootstrap :: currency select :: build payload from input data

21247ed

disable e2e

d34c2c1

zanuka added 17 commits June 22, 2018 15:24

removes bootstrap :: keeps scss / material

dccff5c

update package-lock

ac25315

remove intruder

913e03d

material formatting

1e8bafb

fixes missing material modules

57d4d4b

adds some basic formatting

5bacea5

flex container fixes

c6667bf

fixes lint errors

cb30fcd

tweak to travis test command

cef4780

move coverage dir

ccd5636

nukes material :: nukes flexbox

71d6e16

materialistic

48ce7f0

tweak

3d0c8ab

adds parser, model, stub, tests :: reworks service

8432333

fixes lint errors

0d7908a

fixes lint error and karma conf

ba58b35

adds more tests

59b1ae0

ro-savage reviewed Jun 25, 2018

View reviewed changes

zanuka added 5 commits June 26, 2018 13:05

adds more tests :: removes material remnants

f09f52a

more tests added for verbose response data

926c489

refactors :: remvoves unused material cdk module

db48e09

adds back temp-test-module

f247538

adds tests for API response parser

745e994

ro-savage changed the title ~~Integrate with Kauri API :: GetRawTransactions~~ Integrate with Kauri API :: GetRawTransactions / WIP / DO NOT MERGE Jun 26, 2018

zanuka changed the title ~~Integrate with Kauri API :: GetRawTransactions / WIP / DO NOT MERGE~~ Integrate with Kauri API :: GetRawTransactions Jun 26, 2018

zanuka added 2 commits June 26, 2018 23:31

adds more tx data parse test :: removes redundant tests :: updates model

f94cc85

Merge branch 'master' of github.com:Encrypt-S/kauri-wallet into get-r…

35b39f7

…aw-transactions

zanuka added 3 commits June 27, 2018 00:25

adds aria-labels to form elements

314e5e4

refactors models : parsers :: new package lock json

511aaee

replaces coveralls with codecov

7d5d01e

ro-savage reviewed Jun 26, 2018

View reviewed changes

ro-savage approved these changes Jun 26, 2018

View reviewed changes

modifies no-unused-expression lint rule :: enable killer shortcuts

9e1ccde

zanuka added 2 commits June 27, 2018 10:55

updates CodeCov badge

c5386e3

adds license and repo field to package.json

54e28d9

adds version

3cb5d1d

zanuka merged commit a6071d4 into master Jun 26, 2018

zanuka deleted the get-raw-transactions branch June 26, 2018 23:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integrate with Kauri API :: GetRawTransactions #46

Integrate with Kauri API :: GetRawTransactions #46

zanuka commented Jun 20, 2018 •

edited

red010b37 Jun 20, 2018 •

edited

zanuka Jun 21, 2018

red010b37 Jun 20, 2018

red010b37 left a comment

zanuka commented Jun 21, 2018

matt-auckland commented Jun 25, 2018

zanuka commented Jun 25, 2018 •

edited

ro-savage Jun 25, 2018 •

edited

ro-savage Jun 25, 2018 •

edited

red010b37 Jun 26, 2018 •

edited

ro-savage Jun 25, 2018

zanuka Jun 26, 2018

ro-savage commented Jun 26, 2018

zanuka commented Jun 26, 2018

zanuka commented Jun 26, 2018

codecov-io commented Jun 26, 2018 •

edited by codecov bot

ro-savage Jun 26, 2018 •

edited

zanuka Jun 26, 2018

ro-savage Jun 26, 2018

zanuka Jun 26, 2018

ro-savage left a comment

zanuka commented Jun 26, 2018

		constructor(private http: HttpClient) {}

		getRawTransactions(addresses: any[]) {


		onGetTransactions(currency: string, addresses: string[]) {

		const apiModel: ApiModel = {} as ApiModel;


		<br>

		<input matInput placeholder="Enter Address" type="text" #addressTwo>

Integrate with Kauri API :: GetRawTransactions #46

Integrate with Kauri API :: GetRawTransactions #46

Conversation

zanuka commented Jun 20, 2018 • edited

red010b37 Jun 20, 2018 • edited

Choose a reason for hiding this comment

zanuka Jun 21, 2018

Choose a reason for hiding this comment

red010b37 Jun 20, 2018

Choose a reason for hiding this comment

red010b37 left a comment

Choose a reason for hiding this comment

zanuka commented Jun 21, 2018

matt-auckland commented Jun 25, 2018

zanuka commented Jun 25, 2018 • edited

ro-savage Jun 25, 2018 • edited

Choose a reason for hiding this comment

ro-savage Jun 25, 2018 • edited

Choose a reason for hiding this comment

red010b37 Jun 26, 2018 • edited

Choose a reason for hiding this comment

ro-savage Jun 25, 2018

Choose a reason for hiding this comment

zanuka Jun 26, 2018

Choose a reason for hiding this comment

ro-savage commented Jun 26, 2018

zanuka commented Jun 26, 2018

zanuka commented Jun 26, 2018

codecov-io commented Jun 26, 2018 • edited by codecov bot

Codecov Report

ro-savage Jun 26, 2018 • edited

Choose a reason for hiding this comment

zanuka Jun 26, 2018

Choose a reason for hiding this comment

ro-savage Jun 26, 2018

Choose a reason for hiding this comment

zanuka Jun 26, 2018

Choose a reason for hiding this comment

ro-savage left a comment

Choose a reason for hiding this comment

zanuka commented Jun 26, 2018

zanuka commented Jun 20, 2018 •

edited

red010b37 Jun 20, 2018 •

edited

zanuka commented Jun 25, 2018 •

edited

ro-savage Jun 25, 2018 •

edited

ro-savage Jun 25, 2018 •

edited

red010b37 Jun 26, 2018 •

edited

codecov-io commented Jun 26, 2018 •

edited by codecov bot

ro-savage Jun 26, 2018 •

edited