Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lighthouse performance testing to build #48

Merged
merged 4 commits into from
Jun 26, 2018
Merged

Add lighthouse performance testing to build #48

merged 4 commits into from
Jun 26, 2018

Conversation

ro-savage
Copy link
Contributor

@ro-savage ro-savage commented Jun 25, 2018 •
edited

  • Add lighthouse to build process
  • Fails on score under 98
  • Removed some files and updated gitignore

@ro-savage ro-savage mentioned this pull request Jun 25, 2018
Closed
@ro-savage ro-savage changed the title **Do not merge** Add lighthouse Add lighthouse performance testing to build Jun 25, 2018
@ro-savage
Copy link
Contributor Author

@zanuka @matt-auckland - Ready for review.

zanuka
zanuka approved these changes Jun 26, 2018
View reviewed changes
Copy link
Contributor

@zanuka zanuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎲 I dig it 🎲

@ro-savage ro-savage merged commit f3556b0 into master Jun 26, 2018
@ro-savage ro-savage deleted the lighthouse2 branch June 26, 2018 10:59
@ro-savage ro-savage mentioned this pull request Jun 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanuka zanuka zanuka approved these changes

@matt-auckland matt-auckland Awaiting requested review from matt-auckland

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ro-savage @zanuka