-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds cordova (Don't merge) #49
Conversation
…gnore so we can sort that out later
don't need cordova here
@matt-auckland - I wonder if a lot of the files can be added to .gitignore ? |
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
=======================================
Coverage 84.07% 84.07%
=======================================
Files 13 13
Lines 157 157
=======================================
Hits 132 132
Misses 25 25 Continue to review full report at Codecov.
|
@matt-auckland currently getting the following when building in xcode:
|
also get this when API call is executed: |
@matt-auckland I think using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't able to get the app to build properly on my iPhone 6S running (when running 11.4)
It tries to launch, you get the Cordova icon, but an exception is thrown with the following output:
2018-07-03 15:24:49.332251+1200 Kauri Wallet[2941:1189003] *** Terminating app due to uncaught exception 'NSUnknownKeyException', reason: '[<UIApplication 0x103e016a0> setValue:forUndefinedKey:]: this class is not key value coding-compliant for the key view.'
*** First throw call stack:
(0x183e16d8c 0x182fd05ec 0x183e169f0 0x18476c44c 0x18e0967e4 0x183d24b24 0x18e0951f4 0x18e09ac18 0x18de03e2c 0x18da211d8 0x18d9ef4d4 0x18e01fb1c 0x18d9eedd0 0x18d9eec6c 0x18d9edafc 0x18e68384c 0x18d9ed1ec 0x18e468ac8 0x18e5b6bf8 0x18d9ecc0c 0x18d9ec5a8 0x18d9e95e0 0x18d9e9330 0x186617470 0x18661fd6c 0x10240919c 0x1024157cc 0x18664b878 0x18664b51c 0x18664bab8 0x183dbf404 0x183dbec2c 0x183dbc79c 0x183cdcda8 0x185cc1020 0x18dcf9758 0x102006520 0x18376dfc0)
libc++abi.dylib: terminating with uncaught exception of type NSException```
## Builds | ||
|
||
1. Perform a prod build in `/packages/kauri-wallet`, this will ensure Cordova has something to build with (it looks to `/packages/kauri-wallet/dist/kauri-wallet/` for the files to build with). | ||
1. Run `npm run android` or `npm run ios` depending on which you want to build. If you want to build both run `npm run all` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meant to be step 2.
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be good to add a couple more steps or notes about requirements for cordova CLI globally as well as cd'ing into packages/cordova
before running the build scripts...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
running just the ios
script built out android as well. bug or feature 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using 1. 1. 1. in markdown is easier to edit (the markdown renderer will automatically turn it into a 1 2 3, which means they can be reordered or new items can be inserted easily)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mind blown. why have I never seen that? must be my old age kicking in
[ ] iOS build needs to be tested before I'm happy to merge.
[x]
We also need to figure out what we can safely gitignore.