Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to push isn't considered an error. #53

Closed
karliss opened this issue Aug 16, 2020 · 5 comments · Fixed by #57
Closed

Failure to push isn't considered an error. #53

karliss opened this issue Aug 16, 2020 · 5 comments · Fixed by #57
Assignees
Labels
good first issue Good for newcomers status: stale Inactive issues and PRs type: bug Verified problems that need to be worked on
Projects

Comments

@karliss
Copy link

karliss commented Aug 16, 2020

In case pushing changes fails (most likely due to incorrect permissions) the action and workflow is considered successful.
I expected it to cause a failure.

  Tagging commit...
  Pushing commits to repo...
  remote: Permission to karliss/github-integration-test.git denied to github-actions[bot].
  fatal: unable to access 'https://github.com/karliss/github-integration-test/': The requested URL returned error: 403
  Pushing tags to repo...
  remote: Permission to karliss/github-integration-test.git denied to github-actions[bot].
  fatal: unable to access 'https://github.com/karliss/github-integration-test/': The requested URL returned error: 403
@EndBug EndBug self-assigned this Aug 17, 2020
@EndBug EndBug added type: bug Verified problems that need to be worked on good first issue Good for newcomers labels Aug 17, 2020
@EndBug EndBug added this to To do in Main board via automation Aug 17, 2020
@EndBug EndBug added this to the Typescript-only rewrite milestone Aug 17, 2020
@EndBug
Copy link
Owner

EndBug commented Aug 17, 2020

Hi, thanks for the issue: this should be solved with the next re-write of the action. I can't give you an ETA for now

@EndBug EndBug moved this from To do to In progress in Main board Aug 24, 2020
@EndBug
Copy link
Owner

EndBug commented Aug 24, 2020

Hi, I'd like you to test the rewrite to see if it properly fails when there's a push error.
To do that, please use EndBug/add-and-commit@ts-only
If everything's ok I'll merge it to the master branch and publish it as v5

@github-actions
Copy link

github-actions bot commented Sep 16, 2020

This issue is being marked as "stale" because it has been open 20 days with no activity. Remove the "stale" label or comment, otherwise this will be closed in 5 days.

@github-actions github-actions bot added the status: stale Inactive issues and PRs label Sep 16, 2020
@bmartinez287
Copy link

##[error]Error: warning: Pulling without specifying how to reconcile divergent branches is
discouraged. You can squelch this message by running one of the following
commands sometime before your next pull:

It seems like EndBug/add-and-commit@ts-only does not work yet.

@github-actions github-actions bot removed the status: stale Inactive issues and PRs label Sep 19, 2020
@EndBug
Copy link
Owner

EndBug commented Sep 19, 2020

@bmartinez287 It doesn't seem to be relevant to this issue, let's move this conversation to a new one ;)

@EndBug EndBug added the status: stale Inactive issues and PRs label Sep 19, 2020
Main board automation moved this from In progress to Done Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers status: stale Inactive issues and PRs type: bug Verified problems that need to be worked on
Projects
No open projects
Main board
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants