Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Committer identity unknown" error on v1.6.0 #25

Closed
alyssaruth opened this issue Sep 11, 2023 · 3 comments
Closed

"Committer identity unknown" error on v1.6.0 #25

alyssaruth opened this issue Sep 11, 2023 · 3 comments
Assignees
Labels
status: pinned Should not be labeled as stale type: bug Verified problems that need to be worked on

Comments

@alyssaruth
Copy link

alyssaruth commented Sep 11, 2023

The v1.6.0 release of this action has broken for us with an error about user config. We've pinned to v1.5.1 for the time being as a workaround. It's a private repo, but happy to share any other details that would be useful.

We're using self-hosted runners for our pipeline - not sure if that's relevant but the auto-detected email address ('runner@ks-1cpu-1gi-v56-bxd79-bh2nj.(none)) is the user and name of the pod running the job.

Our config is:

- name: Create tag
  uses: EndBug/latest-tag@v1.5.1
  with:
    ref: '${{ needs.prepare.outputs.VERSION }}'
    description: '${{ needs.prepare.outputs.VERSION }}'

v1.5.1 output (working):

Run EndBug/latest-tag@v1.5.1
  with:
    ref: 2.1.5601.2377
    description: 2.1.5601.2377
    force-branch: false
Setting up git user...
Using '2.1.5601.2377' as tag name.
Creating annotated tag...
Pushing updated tag to repo...
To https://github.com/glean-notes/glean
 * [new tag]         2.1.5601.2377 -> 2.1.5601.2377

v1.6.0 output (not working):

Run EndBug/latest-tag@latest
  with:
    ref: 2.1.5601.1720
    description: 2.1.5601.1720
    force-branch: false
    git-directory: /runner/_work/glean/glean

Running git commands within /runner/_work/glean/glean
Using '2.1.5601.1720' as tag name.
Setting up git user...
Creating annotated tag...
Error: Command failed: git -C /runner/_work/glean/glean tag -a -f -m "2.1.5601.1720" 2.1.5601.1720
Committer identity unknown

*** Please tell me who you are.

Run

  git config --global user.email "you@example.com"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: unable to auto-detect email address (got 'runner@ks-1cpu-1gi-v56-bxd79-bh2nj.(none)')
@EndBug EndBug self-assigned this Sep 11, 2023
@EndBug EndBug added type: bug Verified problems that need to be worked on status: pinned Should not be labeled as stale labels Sep 11, 2023
@EndBug
Copy link
Owner

EndBug commented Sep 11, 2023

Hi, thanks for reporting this
I actually encountered this as well the first time i tested the action (on GitHub-hosted runners!), but wasn't able to reproduce it :/

I'm going to release a patch that adds some debug logs, since as of now there's much debug info to work with. I'm gonna get back to you soon with this ✌🏻

@EndBug EndBug closed this as completed in 1152cc9 Sep 11, 2023
@EndBug
Copy link
Owner

EndBug commented Sep 11, 2023

Alright, it should be fixed now 🚀 (v1.6.1, v1, latest)
Thanks for the report 💖

@all-contributors please add @alyssa-glean for their bug report

@allcontributors
Copy link
Contributor

@EndBug

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @alyssa-glean! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pinned Should not be labeled as stale type: bug Verified problems that need to be worked on
Projects
None yet
Development

No branches or pull requests

2 participants