Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dealing with relative links #3

Closed
EndlessTrax opened this issue Sep 30, 2020 · 2 comments
Closed

Dealing with relative links #3

EndlessTrax opened this issue Sep 30, 2020 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@EndlessTrax
Copy link
Owner

Currently the check_link_for_http_scheme method in the LinkResults class returns None when it sees a relative link starting with a ./ or ../. Same applies to links that start with #.

This links should be parsed and a full URL determined so that it can be passed to the final links dictionary.
@EndlessTrax EndlessTrax added bug Something isn't working good first issue Good for newcomers HacktoberFest labels Sep 30, 2020
@Icelain Icelain mentioned this issue Sep 30, 2020
Closed
@Icelain
Copy link
Contributor

Icelain commented Oct 1, 2020

I've made a pull request solving this issue.

@EndlessTrax
Copy link
Owner Author

#11 Merged, solving this issue. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EndlessTrax @Icelain