Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide TabBar #52

Closed
ducnv55 opened this issue Mar 28, 2017 · 5 comments
Closed

Hide TabBar #52

ducnv55 opened this issue Mar 28, 2017 · 5 comments

Comments

@ducnv55
Copy link

ducnv55 commented Mar 28, 2017

Can you show me how can I hide TabBar (the horizontal scroll view)
I want to hide it when pull down the tableview (to make more space for tableview's content)
Please help me.
Thank you.

@EndouMari
Copy link
Owner

Thanks issue!

We will add that feature and update, please wait.

@EndouMari
Copy link
Owner

Fixed version(0.2.6) has just released. Please use the latest one.

Example code
https://github.com/EndouMari/TabPageViewController/blob/master/Demo/TabPageViewControllerDemo/ListViewController.swift

3 -30-2017 22-24-11

@ducnv55
Copy link
Author

ducnv55 commented Mar 30, 2017

Thank you so muchhhhh 👍

@ducnv55
Copy link
Author

ducnv55 commented Apr 14, 2017

Sorry for late response.
I just used your lib, everything works fine. Thank you for this feature.
But can you make more options to hide ONLY Scroll page View (not include navigation bar)

I can add code to show navigation bar, but app show a Black space when navigation bar animated.

One more thing, can you fix your lib to hide Scroll page view when dragging, even when drag slowly?
Currently, your lib only hide Scroll page view when release dragging & drag fast, not while dragging

Very appreciate if you have this feature.

@ducnv55
Copy link
Author

ducnv55 commented Apr 14, 2017

I forked your lib and fix above issue.
I add another option in TabPageOption, named "hidesNavigationBarOnSwipe"
When hidesNavigationBarOnSwipe == true, navigation bar will be hidden.
When hidesNavigationBarOnSwipe == false, navigation bar will be shown.

Please accept my commit and merge it into master. Thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants