Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIUX-74 New box deployment for caddy and frontend #30

Merged
merged 18 commits into from Oct 6, 2021
Merged

UIUX-74 New box deployment for caddy and frontend #30

merged 18 commits into from Oct 6, 2021

Conversation

EngineersBox
Copy link
Owner

@EngineersBox EngineersBox commented Sep 29, 2021 •
edited

Changelog

  • Added new ansible inventory, now two exist as inventory/old.ini and inventory/prod.ini
  • Added new GH workflow input to specify which inventory to use (passed to -i with ansible-playbook command)
  • Dockerized caddy deployment with gateway passthrough for API and frontend access
  • Dockerized frontend via npm's http-server lib to serve on port 3002
  • Refactored playbook to target new frontend build instead of old
  • Refactored user pass provide to switch based on workflow target
  • Refactored mentions of elasticsearch to opensearch`
  • Added missing containers for each opensearch node
  • Fixed dockerfile contexts
  • Refactored backend dockerfile to have stricter copy-in for reduced size

@EngineersBox EngineersBox marked this pull request as ready for review October 3, 2021 07:03
@EngineersBox EngineersBox added the enhancement New feature or request label Oct 3, 2021
@EngineersBox EngineersBox marked this pull request as draft October 4, 2021 05:52
@EngineersBox EngineersBox marked this pull request as ready for review October 5, 2021 10:18
XuguangSong98
XuguangSong98 previously approved these changes Oct 6, 2021
View reviewed changes
Copy link
Collaborator

@XuguangSong98 XuguangSong98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@EngineersBox EngineersBox requested review from WeiXinFam and removed request for jayjayjayjayjayjay October 6, 2021 02:38
WeiXinFam
WeiXinFam reviewed Oct 6, 2021
View reviewed changes
Copy link
Collaborator

@WeiXinFam WeiXinFam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me. Just need end of line fr some of the files

Dockerfile Outdated Show resolved Hide resolved
@EngineersBox
Copy link
Owner Author

@WeiXinFam @alooba1 Have added the newlines, as per Fam's comment. Good for re-review

@EngineersBox EngineersBox removed the request for review from FinalYou October 6, 2021 05:24
WeiXinFam
WeiXinFam approved these changes Oct 6, 2021
View reviewed changes
Copy link
Collaborator

@WeiXinFam WeiXinFam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to me

@EngineersBox EngineersBox merged commit a88e41b into main Oct 6, 2021
@EngineersBox EngineersBox deleted the UIUX-74-New-Box-Ansible-GH-Workflow-Updates branch October 6, 2021 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeiXinFam WeiXinFam WeiXinFam approved these changes

@XuguangSong98 XuguangSong98 XuguangSong98 left review comments

Assignees
No one assigned
Labels
deployment enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EngineersBox @WeiXinFam @XuguangSong98