Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IC2 Patcher to fix IC2? #1983

Open
Shijikori opened this issue Jan 2, 2022 · 15 comments
Open

Add IC2 Patcher to fix IC2? #1983

Shijikori opened this issue Jan 2, 2022 · 15 comments

Comments

@Shijikori
Copy link

URL

https://www.curseforge.com/minecraft/mc-mods/ic2-patcher

Why would you like the mod added?

I faced the issue where the QuantumSuit in IC2 can't have it's JetPack disabled. I also found out that this issue, along quite a few others, don't seem like they will be officially fixed by the IC2 developers. I've found this mod which claims to patch most of these issues. I haven't tried it myself yet but I intend to give it a shot as not being able to disable the JetPack is very annoying.

@Shijikori
Copy link
Author

I have tried IC2 Patcher and it does fix issues with keybinds.

@ElektroKill
Copy link

ElektroKill commented May 8, 2022

This would require updating IC2 to the latest beta version. Not sure what exactly changed in the versions between the current one and the latest one but there could be breaking changes!

@NielsPilgaard
Copy link
Collaborator

Last time I updated IC2 it introduced several dupe bugs, so I'm reluctant to do that 😅

@ReiDaTecnologia
Copy link

God damnit xD
but ngl, the jetpack bug is really annoying...

@ElektroKill
Copy link

Last time I updated IC2 it introduced several dupe bugs, so I'm reluctant to do that 😅

Yeah, IC2 is well known for dupe bugs... I think an update would be useful as it fixes some bugs within IC2 and allows usage of the mod which fixes even more bugs and annoyances. The IC2 Patcher mod also has a better fix for the Batch Crafter duplication bug instead of just disabling it outright allowing people to use the block in their worlds instead of having it disabled.

IC2Patcher has such a strict dependency on the version because it uses binary patches to patch the bugs in IC2 which easily break when the code is not the same.

@MommyHeather
Copy link

So, the only reason we can't do this is because of the dependency? Does anyone know if this fixes the issues with the enet failing sometimes?

@NielsPilgaard
Copy link
Collaborator

If it does then I'm less reluctant to update.

@Shijikori
Copy link
Author

So, the only reason we can't do this is because of the dependency? Does anyone know if this fixes the issues with the enet failing sometimes?

The bugs IC2 Patcher patches are listed on the CurseForge page. No mentions of enet. I took a look at their issue tracker on their GitHub, I didn't find a specific reference to enet. You can request a bug to be patched on there.

@ThePixelbrain
Copy link

As of recently, IC2Patcher has a patch for an enet bug. This might be something worth revisiting.

@Shijikori
Copy link
Author

Yep, they merged an enet related patch in may : Su5eD/IC2-Patcher#9

@Shijikori
Copy link
Author

Good job on that btw @ThePixelbrain

@Discomanco
Copy link
Collaborator

This likely wont happen.

IC2Patcher needs a very recent version of IC2. Any IC2 version above the one we're using right now, have autocrafting with AE2 completely broken. It works with AE2UEL, but that's not a switch we can do outside of an update that would require people to remake worlds, which is not ideal, so that also wont happen.

We tried for E2E 1.90, but the IC2 issues with AE2 were not acceptable, and it wont be fixed from either side.

@NielsPilgaard NielsPilgaard closed this as not planned Won't fix, can't repro, duplicate, stale Jul 25, 2023
@Kanzaji
Copy link
Contributor

Kanzaji commented Sep 21, 2023

👀
Su5eD/IC2-Patcher#12

@MommyHeather
Copy link

MommyHeather commented Sep 21, 2023

👀 Su5eD/IC2-Patcher#12

Fucking madlad made a pr for ic2patcher just so we can get it in e2e

@Kanzaji
Copy link
Contributor

Kanzaji commented Oct 1, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants