Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotations to changed files #32

Closed
AntonOellerer opened this issue Oct 20, 2020 · 3 comments
Closed

Add annotations to changed files #32

AntonOellerer opened this issue Oct 20, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@AntonOellerer
Copy link

Hey, I really like your library!
Is there a plan currently to implement adding annotations so that they can be seen in the "files changed" tab?
Best regards
Anton

@EnricoMi
Copy link
Owner

This is a bit tricky to achieve given the way github works. The files changed tab only shows those parts of files that have changed. The unit test result files used by the action to report test results only report which unit tests in which unit test files and lines failed. Both things usually don't occur at the same time, unless you have touched a unit test (changed files) that fails (unit test result). Usually you change code and unit tests fail.

I think the current annotations provided by the action already implements that rare case.

I think what you refer to (and I agree that would be useful) is a snippet of the unit test that failed, regardless of it's change state (changed files). Maybe a link to the source line would work (given the action knows the commit, file and line).

@EnricoMi EnricoMi added the enhancement New feature or request label Oct 22, 2020
@AntonOellerer
Copy link
Author

Ah I see, thank you!

@EnricoMi
Copy link
Owner

Happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants