Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit check run fields size #52

Closed
EnricoMi opened this issue Nov 11, 2020 · 0 comments · Fixed by #70
Closed

Limit check run fields size #52

EnricoMi opened this issue Nov 11, 2020 · 0 comments · Fixed by #70
Labels
bug Something isn't working

Comments

@EnricoMi
Copy link
Owner

Github API limits the size of some API call JSON fields, especially when creating check runs:
https://developer.github.com/v3/checks/runs/#annotations-object-1

Annotation:

  • message: 64 KB
  • title: 255 characters
  • raw_details: 64 KB

Limit these fields by abbreviating the strings with ellipsis in the middle of the string. Make sure the title cannot get larger than 255 characters without abbreviating it.

Limiting a string by bytes is tricky as some characters may use multiple bytes. Easiest would be to limit it to 16k characters, which should be safe in terms of bytes in any situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant