Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

const fns missing const #41

Closed
Enselic opened this issue Mar 7, 2022 · 2 comments · Fixed by #79
Closed

const fns missing const #41

Enselic opened this issue Mar 7, 2022 · 2 comments · Fixed by #79
Labels
limitation A current limitation of the library, e.g. due to an upstream bug.

Comments

@Enselic
Copy link
Owner

Enselic commented Mar 7, 2022

Should be pretty easy to add because the JSON for a function has the necessary info:

                "header": {
                    "const": false,
                    "unsafe": false,
                    "async": true,
                    "abi": "Rust"
                }
@Enselic Enselic added the limitation A current limitation of the library, e.g. due to an upstream bug. label Mar 7, 2022
douweschulte added a commit to douweschulte/public-api that referenced this issue Apr 1, 2022
@douweschulte
Support for Enselic#41 in tokenization
dff7796
@Enselic
Copy link
Owner Author

Enselic commented Apr 16, 2022

The groundwork for this was done by @douweschulte in #53, but const didn't quite work, and we should add regression tests for the other ones, so I will keep this open for a while longer.

@Enselic Enselic mentioned this issue Apr 17, 2022
Merged
@Enselic
Copy link
Owner Author

Enselic commented Apr 17, 2022

#74 added tests for async and unsafe and it works good enough. I'll let this issue only be about const fns from now on.

@Enselic Enselic changed the title Keywords async, unsafe, const not included in output for fns const not included in output for const fns Apr 17, 2022
@Enselic Enselic changed the title const not included in output for const fns const fns missing const Apr 17, 2022
@Enselic Enselic mentioned this issue Apr 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
limitation A current limitation of the library, e.g. due to an upstream bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support const fn Enselic/public-api
1 participant
@Enselic