Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Make the preview tab remember scroll position when you switch from and back to it #142

Closed
yaksher opened this issue Oct 20, 2023 · 4 comments · Fixed by #145
Closed

Feature request: Make the preview tab remember scroll position when you switch from and back to it #142

yaksher opened this issue Oct 20, 2023 · 4 comments · Fixed by #145
Labels
enhancement New feature or request

Comments

@yaksher
Copy link

yaksher commented Oct 20, 2023

Currently, when you switch to another tab from a preview window, when you switch back, it's at the start of the file. This becomes pretty inconvenient if the file you're editing is very large, because in partial rendering mode it's currently slow to scroll to the end again or whatever.
@yaksher yaksher changed the title Make the preview tab remember scroll position when you switch from and back to it Feature request: Make the preview tab remember scroll position when you switch from and back to it Oct 20, 2023
@Enter-tainer
Copy link
Owner

it is hard because when a tab is not visible, vscode deactivates it. and when it is visible again, everything begins from scratch.

but i agree it is good to have this feature

@Enter-tainer Enter-tainer added the enhancement New feature or request label Oct 20, 2023
@yaksher
Copy link
Author

yaksher commented Oct 20, 2023

That's fair; I'm not aware of the details of VS Code plugins. My thought was that the PDF preview extension somehow does support this, but maybe file display tabs have special privileges even if they're displaying a non-text file?

@Enter-tainer
Copy link
Owner

I will have a look on that. Perhaps this is not as hard as I imagined

@Enter-tainer
Copy link
Owner

related:
microsoft/vscode#22995
microsoft/vscode#27498
https://code.visualstudio.com/api/extension-guides/webview#retaincontextwhenhidden

@Enter-tainer Enter-tainer mentioned this issue Oct 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: retain webview ctx when hidden Enter-tainer/typst-preview
2 participants
@yaksher @Enter-tainer