-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding scripted browser monitor for newrelic synthetics monitoring #584
Conversation
…serverless into ish-synthetics
…serverless into ish-synthetics
.then(function () {}) | ||
// Test Case: login-test | ||
.then(function () { | ||
return Promise.resolve(true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
(console.log( | ||
`Step ${a}: ${o} FINISHED. It took ${_}ms to complete. testCase=${i}` | ||
), | ||
t && n.length > 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
endTestCase: function (e = "") { | ||
var i = Date.now() - r - s; | ||
console.log(`Step ${a}: ${o} FINISHED. It took ${i}ms to complete.`), | ||
t && n.length > 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
const By = $driver.By; | ||
const browser = $browser.manage(); | ||
var vars = new Map(); | ||
const logger = (function ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function logger
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Code Climate has analyzed commit 8aa2419 and detected 4 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 24.4% (0.0% change). View more on Code Climate. |
Purpose
This PR adds scripted browser monitor for newrelic synthetics monitoring.
Linked Issues to Close
Closes #583
Approach
This change implement the newrelic synthetics monitor(scripted browser) through the syhthtetic api.
Pull Request Creator Checklist
Pull Request Reviewer/Assignee Checklist