Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test doc string #14

Closed
edoddridge opened this issue Dec 13, 2018 · 1 comment
Closed

Test doc string #14

edoddridge opened this issue Dec 13, 2018 · 1 comment

Comments

@edoddridge
Copy link

Submitted as part of a review for JOSS.

In the buffer tests, something is wrong with one of the doc strings. It says a 10x10 grid with dx=0.2 and limits of (0,0) and (4,4). Either the size, the limits, or the dx must be wrong.

https://github.com/EnvModellingGroup/hdrs/blob/7c7a095cee17b3af79daa0b3fed874fee5e4e9eb/tests/test_buffer.py#L69-L72
@jhill1 jhill1 mentioned this issue Dec 19, 2018
Merged
@jhill1
Copy link
Contributor

jhill1 commented Dec 19, 2018

Fixed in #17

@jhill1 jhill1 closed this as completed Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jhill1 @edoddridge