Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: HTML-Links to folder note files do not work (Local folder) #17

Closed
3 tasks done
emign opened this issue Jul 29, 2022 · 6 comments
Closed
3 tasks done

[Bug]: HTML-Links to folder note files do not work (Local folder) #17

emign opened this issue Jul 29, 2022 · 6 comments
Assignees
Labels
🦆 Duplicate This issue or pull request already exists ✖️ Wontfix This will not be worked on

Comments

@emign
Copy link

emign commented Jul 29, 2022

Issue validation

Workflow

Obsidian plugin 💠

Describe the bug

Hallo,

I really love your plugin. I use obs2mk in a docker container to convert my obsidian markdown file-structure to an mkdoc page. I use this line in a bash script:

find /docs -type f -name \*.md -exec bash -c 'FN="{}"; obs2mk --minimal file "{}"' \;

I have the following folder structure:
image
note that the icons are from the folder-icons plugin and do not belong to the filenames

Please checkout the resulting mkdocs file here: https://unterricht.emig.me/Unterricht/Fächer/Biologie/NuT/Ökosystem%20Grünland/

The links to the folder-note files do not work. They are not correctly linked.
For example the link to "Stoffwechsel" points to ../../../../Stoffwechsel instead of ../Der%20%Mensch%20als%20Lebewesen/Stoffwechsel
Please note, that the link in the navigation bar on the left is correctly created

How to reproduce ?

  1. In Obsidian: Create a folder and inside that a MD file with the same name as the folder (folder-note)
  2. Link to the folder note markdown file from an external markdown file
  3. Convert files using obs2mk

Configuration

using --minimal argument it should use your minimal config:

minimal:
  configuration:
    input: null
    output: null
  frontmatter:
    category:
      default value: notes
      key: category
    index: (i)
    share: share
  weblink: null

Relevant log output

No response

OS

Linux

Anything else?

No response

@Mara-Li
Copy link
Member

Mara-Li commented Jul 29, 2022

Huuuuuuuuuuh
Did you try without using the old python plugin ?
I saw (on my own file) that sometimes, python broke completely the filepath.

Without it, I can't understand why this error append. The code for relative path is pretty simple so, maybe I forgot something, or maybe I'm pretty stupid. Dunno.

@emign
Copy link
Author

emign commented Jul 29, 2022

What do you mean by 'without using the old python plugin?' ?
is osb2mk not maintained anymore?
The problem I have with using the obsidian plugin is, that I have to use a git repo which is hosted on my own server instead of GitHub

@Mara-Li
Copy link
Member

Mara-Li commented Jul 30, 2022

As I said in the documentation, obs2mk is deprecated. I prefer to maintain the obsidian plugin.

You can totally maintain obs2mk if you want !

More over, I think i will work on a way to use a local folder and other Git solution (at last Gitlab and Gitea).

@emign
Copy link
Author

emign commented Jul 30, 2022

Sorry I did not see that in the documentation.
I am considering contributing to obs2mk

And it would be really awesome if you would integrate local folder or general git support (not only gitlab etc)

@emign emign closed this as completed Jul 30, 2022
@Mara-Li
Copy link
Member

Mara-Li commented Jul 30, 2022

The problem around local is simple : i dont want to broke mobile. So i need to found a way to disable this option on mobile !
I think i will work on that this summer :)

@Mara-Li
Copy link
Member

Mara-Li commented Aug 6, 2022

Hello ! I started to work on local folder, but it's a highly destructive behavior, with a lot of work for a niche usage (at my side).
If you want to help me, you can check the branch "local_folder" and help me to test and try !

@Mara-Li Mara-Li reopened this Aug 6, 2022
@Mara-Li Mara-Li mentioned this issue Aug 6, 2022
2 tasks
@Mara-Li Mara-Li closed this as completed Aug 6, 2022
@Mara-Li Mara-Li added 💎 Obsidian Github Publisher 🦆 Duplicate This issue or pull request already exists ✖️ Wontfix This will not be worked on and removed 🐛 Bug labels Feb 4, 2023
@Mara-Li Mara-Li closed this as not planned Won't fix, can't repro, duplicate, stale Feb 4, 2023
@Mara-Li Mara-Li changed the title [Bug]: HTML-Links to folder note files do not work [Bug]: HTML-Links to folder note files do not work (Local folder) Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦆 Duplicate This issue or pull request already exists ✖️ Wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants