Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sum wrong gradient on Julia 1.10-nightly #1119

Closed
jgreener64 opened this issue Oct 29, 2023 · 3 comments
Closed

sum wrong gradient on Julia 1.10-nightly #1119

jgreener64 opened this issue Oct 29, 2023 · 3 comments

Comments

@jgreener64
Copy link
Contributor

On Enzyme main (b635408) and Julia 1.10-nightly this gives the wrong gradient:

using Enzyme
f(x) = sum(diff([0.0 x; 1.0 2x]; dims=2))
autodiff(Reverse, f, Active, Active(2.0))[1][1]
1.0 # Should be 3.0

See the CI logs at https://github.com/EnzymeAD/Enzyme.jl/actions/runs/6678494431/job/18149594449?pr=969.

@wsmoses
Copy link
Member

wsmoses commented Nov 8, 2023

This no longer reproduces for me on main, please reopen if it persists [and I suppose rebase that PR?]

@wsmoses wsmoses closed this as completed Nov 8, 2023
@jgreener64
Copy link
Contributor Author

On CI on Julia 1.10-nightly this seems to be throwing a StackOverflowError: https://github.com/EnzymeAD/Enzyme.jl/actions/runs/6797095128/job/18478504650?pr=969.

Also for the following:

using Enzyme
f(x) = rot180([x 2x; 3x 4x], 3)[1, 1]
autodiff(Reverse, f, Active, Active(2.0))[1][1] # Should be 4.0

@wsmoses
Copy link
Member

wsmoses commented Nov 8, 2023

yeah 1.10 broke upstream recently, a seprarate issue was opened for that: #1134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants