Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing docstrings for types used in custom reverse rules #704

Closed
gaurav-arya opened this issue Apr 7, 2023 · 1 comment · Fixed by #697
Closed

Missing docstrings for types used in custom reverse rules #704

gaurav-arya opened this issue Apr 7, 2023 · 1 comment · Fixed by #697
Labels
good first issue Good for newcomers

Comments

@gaurav-arya
Copy link
Member

gaurav-arya commented Apr 7, 2023 •
edited

AugmentedReturn and Config are missing docstrings. It would be nice to have them since the user must use these ypes when writing a custom reverse rule.
@wsmoses
Copy link
Member

wsmoses commented Apr 7, 2023

PR's welcome!

@wsmoses wsmoses added the good first issue Good for newcomers label Apr 7, 2023
@gaurav-arya gaurav-arya changed the title Missing docstring for AugmentedReturn Missing docstrings for types used in custom reverse rules Apr 7, 2023
@gaurav-arya gaurav-arya mentioned this issue Apr 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Custom rule doc example gaurav-arya/Enzyme.jl
2 participants
@wsmoses @gaurav-arya