Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression #796

Closed
michel2323 opened this issue Apr 28, 2023 · 7 comments
Closed

Performance regression #796

michel2323 opened this issue Apr 28, 2023 · 7 comments

Comments

@michel2323
Copy link
Collaborator

michel2323 commented Apr 28, 2023

I observed a regression issue going from Enzyme.jl v0.11.0 to v0.11.1.

v0.11.1:

401.197621 seconds (69.04 M allocations: 4.089 GiB, 99.80% compilation time)

v0.11.0:

81.696286 seconds (46.88 M allocations: 2.844 GiB, 99.41% compilation time)

The pprof files are attached.

The code is the one by @swilliamson7 https://github.com/DJ4Earth/eddy-stresses/blob/main/src/main_energy_1.jl .
profile_11.0.pb.gz
profile_11.1.pb.gz

@swilliamson7
Copy link
Collaborator

swilliamson7 commented Apr 28, 2023

That repo isn't set to public, but I just put the newest version of the code here: https://github.com/DJ4Earth/DJ-barotropic-gyre. The scripts Michel is referring to are in explicit_solver, and the file main_energy_1_chkp.jl runs the whole model

@vchuravy
Copy link
Member

vchuravy commented Apr 28, 2023

@wsmoses
Copy link
Member

wsmoses commented May 8, 2023

Retry on main?

@michel2323
Copy link
Collaborator Author

michel2323 commented May 9, 2023

Some preliminary report after fiddling with it for a while. I somehow get a new error with v0.11.1 and main, which drops after 8 minutes or something. v0.11.0 goes through as usual. Attached is the error log. I thought it's something on in our code that changed, but it may be related to the Julia version or the system (development server is down today). I have to investigate more...
bug_11.1.log

@wsmoses
Copy link
Member

wsmoses commented May 9, 2023

@michel2323 can you rerun with this branch and post the log? #822 It just adds some extra information so we can figure out what's going awry.

@michel2323
Copy link
Collaborator Author

@wsmoses Here are the logs. There are two. One with GC enabled and one with GC disabled because they give a different printout.
logs.zip

@wsmoses
Copy link
Member

wsmoses commented May 9, 2023

@michel2323 try again on main, I think it should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants