Change 'size()' function calls to 'length'

[freemer]

size() has been removed from jQuery 3

[steveyj79]

nice fix, is this going to be merged to the build?

[priley86]

+1, would like to see this fix

[meijdenmedia]

When will this fix be deployed?

[steveyj79]

it won't until the tests are fixed the CI build is failing @freemer

[tsneed290]

Forgive me @steveyj79 if I am misunderstanding the failing build. Why would the two commits in this pull request have anything to do with Travis throwing an NPM "EPEERINVALID" error code?

Eagerly awaiting this fix :)

Regards,
T

[steveyj79]

@tsneed290 not sure why could of been built on an older version of the branch i've not checked whats actually failing in the build, just know the build won't be merged until; the tests have been fixed. by all means try forking off the last release applying the same fix and see if the build fails or not

[tsneed290]

Thanks @steveyj79 for the suggestion, will try that later.

[tsneed290]

Hey @steveyj79, created a new pull request that passes #1726. Let me know if you see any problems.

Bummer, this fix doesn't work as intended (the popup is blank). Will cancel my PR and investigate further.

Re-opened PR, the fix does work, I had old CSS leaking through that caused the unintended consequences.

[steveyj79]

new fix #1726

[Synchro]

This build failure looks like a Travis-Ci env issue, nothing to do with this PR. Restarting it may work.

[nicolashohm]

The size()/length fix is already done in 0202134