Fix CommonJS export #1771
Closed
Fix CommonJS export #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍, this happens whenever you use |
Export line inside factory function had not restrictive enough check that may
caused global namespace polluting problem during Karma test. Karma has a
`window.module` alias for `angular.mock.module` method used during tests. And as
a result other libs that may check for CommonJS env could erroneously try to use
`require` method which is non-existing in browser env. Example:
```javascript
if (typeof module !== 'undefined' && module.exports) {
// CommonJS
module.exports = factory(require('angular'));
}
```
On the other hand this assignment inside factory function was overwritten by
the outcome of factory function itself in following line:
```javascript
module.exports = factory(require('jquery'), require('moment'));
```
As a result when we had tried to `require('./bootstrap-datetimepicker.js')` in
other script file, we got `undefined`.
memee
force-pushed
the
fix-commonjs-check
branch
from
891dd82
to
1fc13ac
Compare
|
Per the contrib doc, please make your PRs to the development branch. PRs to the master will be closed. |
Repository owner
locked and limited conversation to collaborators
Jun 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export line inside factory function had not restrictive enough check that may
caused global namespace polluting problem during Karma test. Karma has a
window.modulealias forangular.mock.modulemethod used during tests. And asa result other libs that may check for CommonJS env could erroneously try to use
requiremethod which is non-existing in browser env. Example:On the other hand this assignment inside factory function was overwritten by
the outcome of factory function itself in following line:
As a result when we had tried to
require('./bootstrap-datetimepicker.js')inother script file, we got
undefined.