Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPDATE] For the future going forward #298

Open
Ephenia opened this issue Apr 19, 2023 · 9 comments
Open

[UPDATE] For the future going forward #298

Ephenia opened this issue Apr 19, 2023 · 9 comments

Comments

@Ephenia
Copy link
Owner

Ephenia commented Apr 19, 2023

Dear all,

I hope this message finds you well. I'm writing to provide an update for everyone who's interested and on board with this project still.

Firstly, I want to express my gratitude for all the support and interest shown in the project thus far. You all have played a critical role in advancing the project to where it stands today. However, I feel the need to address an issue that has been on my mind for some time now.

Lately, I have been struggling to find the motivation to continue working on the project and have been for quite a long time now. I am sure this has already been obvious to some. This is not something that I've come to terms lightly with, but I think it's important to be transparent with this project's community that surrounds it. Despite my lack of enthusiasm, I do believe that the project here has the potential to continue be great,

With that said, I've come up with a solution that I believe can benefit everyone involved. Going forward, I will be accepting pull requests for the project, but I won't be reviewing them personally. Instead, pull requests will be put to a vote among the community. If enough people vote in favor of a pull request (in reaction form with positive reactions), or if the reviewal shown is good enough, I will approve it without my own personal review. This way, the project can continue to progress without my direct involvement while still maintaining a good level of quality and ensuring contribution doesn't just go to waste and it will continue to be welcome.

I encourage everyone to go and vote on all the open PRs currently and or start giving reviews of them where needed and then we'll start working and going from there.

To keep it more simple, 👍 if you want something, 👎 if you don't want something.

I understand that this is a significant change to the project, but I believe it's the best way forward given my current level of motivation with it. I hope that everyone who's interested and on board with the project can come together and continue to build something great with it, and I'm excited to see where the project goes from here.

I may still help here and there and be present, but I think this is the direction I feel is best for the project for now and trying to make things more fair for everyone.

Thank you for your understanding and continued support.

@Ephenia Ephenia pinned this issue Apr 19, 2023
@wintersnow5174
Copy link

I am proud of you for reflecting on what you needed, that is a very hard thing to do.

I think you have come with a nice hybrid way of keeping things going while allowing you to pull back and focus on other things that bring you joy.

I look forward to the future.

@Ephenia
Copy link
Owner Author

Ephenia commented Apr 19, 2023

Another thing to add, I have also added the Merge Conflicting tag, and this has now been added to PRs currently that have a merge conflict.

These would need to either be resolved by the Author of the PR and or someone else who wishes to propose changes that can resolve them if they wish to do so.

Keep in mind that it's still fine to vote on PRs that have a merge conflict, but note that most likely nothing will happen with the PR if my stance also remains at least neutral with them. So they won't just be closed, however, just unable to be implemented in their current state.

@umbralOptimatum
Copy link
Contributor

umbralOptimatum commented Apr 19, 2023

Thank you for taking the time to write. The community voting plan seems promising. Hobby projects have a nasty tendency to outgrow their creators' time and interest; I'm glad you've found a way for this project to continue growing without becoming burdensome. And perhaps, without the burden of responsibility for everyone else's code and issues, we'll see involvement from you again in future.

@Ephenia
Copy link
Owner Author

Ephenia commented Apr 29, 2023

Note: I do and am checking back regularly just FYI. Almost every day if I can.

Another label has been added named Insufficient votes.

This label is quite self explanatory, it means that the PR needs more votes and or attention before I would consider doing anything with it. Almost all PRs open at the moment would be given this, but this hopefully better helps visibility of the recent shift in the project's direction. People need to better understand that the project isn't dead 👍

@Ephenia
Copy link
Owner Author

Ephenia commented May 7, 2023

Just leaving this here too as a future note for others doing PRs that update the app.asar file.

If you are updating the file itself, make sure that you also commit the app_src folder along with it with the update to the file.

Doing the app.asar file itself will result in a merge conflict.

@umbralOptimatum
Copy link
Contributor

Is there a set number of votes necessary to approve a PR, or is it a case by case decision?

@Ephenia
Copy link
Owner Author

Ephenia commented May 9, 2023

Is there a set number of votes necessary to approve a PR, or is it a case by case decision?

Case by case decision, there's some bias on my behalf with it. But, I will try to make it as fair and be objective as possible.

@Ephenia
Copy link
Owner Author

Ephenia commented Jul 8, 2023

As of now and for the foreseeable future, PRs must have at least 10 positive votes to pass swiftly through approval.

If there are negative votes, then there still needs to be at least 10 positive ones AND the positive votes are required to have over a 90% approval rating. This cannot be 90% and must be 91% or greater.

@Ephenia
Copy link
Owner Author

Ephenia commented Jul 9, 2023

As of now and for the foreseeable future, PRs must have at least 10 positive votes to pass swiftly through approval.

If there are negative votes, then there still needs to be at least 10 positive ones AND the positive votes are required to have over a 90% approval rating. This cannot be 90% and must be 91% or greater.

This also doesn't apply to PRs that are fixing bugs and whatnot that are more urgent, whether this is from a PR that had just passed through and was approved or something being fixed due to a version update on the game, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants