Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bringing Back Stock Price Retrieving Through The Gui. #4

Closed
CodingAviator opened this issue Aug 6, 2022 · 5 comments
Closed

Bringing Back Stock Price Retrieving Through The Gui. #4

CodingAviator opened this issue Aug 6, 2022 · 5 comments
Assignees
@MahaMohan @CodingAviator
Labels
Code Enhancement New feature request be added to the Code Help Wanted Extra attention and help is needed

Comments

@CodingAviator
Copy link
Member

It was possible to retrieve stock prices before and now it has been removed due to an error.
This request is to bring it back and also improve the documentation by explaining to users about the Jaraudit Text File.
@CodingAviator CodingAviator added Documentation Improvements or additions to documentations Code Enhancement New feature request be added to the Code good first issue Help Wanted Extra attention and help is needed labels Aug 6, 2022
@MahaMohan
Copy link
Member

We have brought back the stock retrieval features in commit 88626d6. But it can only retrieve how much the stock have changed since the previous day.
Ex. AAPL Stock change is +0.43
Rather than AAPL Stock price is 334.50 usd

We will be continuing to work on this issue and any help will be appreciated.

This problem is towards Web scraping and apis and not related to the gui or layout side of JARVIS.

@MahaMohan
Copy link
Member

We have also improved the documentation(README.md) to include the importance and uses of Jar-Audit file in the commit 88626d6 for the users to understand.

@CodingAviator
Copy link
Member Author

Thank you for your time and dedication to fix this errors and help to improve user understandability.
We will continue to work on bringing back the legacy stock retrieval program.

@CodingAviator CodingAviator removed the Documentation Improvements or additions to documentations label Aug 10, 2022
@MahaMohan
Copy link
Member

IT'S A WRAP!!!
As of the latest commit 0c6d067 We have successfully integrated the ability to fetch current stock prices into JARVIS.
All it took was for us to learn some web-scraping online.

@CodingAviator
Copy link
Member Author

Thank you @MahaMohan for taking your time to finish this issue.
With this commit this issue will be archived.
Thanks team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MahaMohan MahaMohan

@CodingAviator CodingAviator

Labels
Code Enhancement New feature request be added to the Code Help Wanted Extra attention and help is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MahaMohan @CodingAviator