File separation #99
Closed
File separation #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't checked the code if it has worked or not. |
|
Some are blank for some reason idk why |
|
Finished adding the code to the blank files |
|
Sorry for the all commits doing this in the browser |
|
@TheUntraceable Done |
TheUntraceable
requested changes
Mar 10, 2022
|
Alr |
nav-github01001
suggested changes
Mar 11, 2022
There was a problem hiding this comment.
@Jerry-py Can you look at my fork of this pr and try to apply changes in it?
https://github.com/nav-github01001/EpikCord.py/tree/patch-8
|
@TheUntraceable Done |
| @@ -210,6 +210,36 @@ def __init__(self, client, data: dict): | |||
| self.channel_id: str = data.get("channel_id") | |||
| self.privacy_level: int = data.get("privacy_level") | |||
| self.discoverable_disabled: bool = data.get("discoverable_disabled") | |||
| class TextBasedChannel: | |||
There was a problem hiding this comment.
This is meant to be client.utils.channel_from_type(dict)
|
We have conflicts idk how to resolve |
|
So i wanna say we have to close this |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
File separation
Checklist
Additional context