Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many dynamic allocations #9

Closed
luiswirth opened this issue May 29, 2018 · 2 comments
Closed

Too many dynamic allocations #9

luiswirth opened this issue May 29, 2018 · 2 comments

Comments

@luiswirth
Copy link

In my opinion, you are overusing dynamic allocation. If it isn't necessary, you should avoid it, because it is a very slow operation. I don't see the point of making most members of a class pointers to dynamic memory. Please consider changing this.

@mattparks
Copy link
Member

There are areas where this can definitely be reduced, mainly in file loading and per-frame updates (used minimally for this currently). A lot of the time dynamic allocations are used in objects where the lifetime lasts the runtime length. I will definitely start to remove dynamic allocation usages starting now, thanks for the feedback.

@luiswirth
Copy link
Author

Great! By the way: Nice game engine!

@mattparks mattparks mentioned this issue May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants