Writing keywords with ecl_file on OS X fails #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joakim-hove
approved these changes
Jun 6, 2017
joakim-hove
reviewed
Jun 8, 2017
| return -1; | ||
|
|
||
| int flush_status = fflush(fortio->stream); | ||
| if(flush_status != 0) |
There was a problem hiding this comment.
Are the ftell( ) and fseek( ) calls necessary?
There was a problem hiding this comment.
Yes, because the position in the stream after a flush is undefined. And in particular, it results in funky behaviour with clang on OS X..
markusdregi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
The EclKW test fails on OS X.
Approach
It turned out to be an problem with ecl_file/fortio in C. The problem occurred in ecl_file_save_kw and the solution was to flush the fortio stream after skipping the header, but before writing the data.
Pre un-WIP checklist