Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing mapaxes #63

Merged
merged 1 commit into from
May 16, 2017
Merged

Exposing mapaxes #63

merged 1 commit into from
May 16, 2017

Conversation

markusdregi
Copy link
Contributor

Exposes mapaxes in Python. Made the C-function consistent with the corresponding functions for the other keywords..

@markusdregi markusdregi changed the title Exposing mapaxes WIP: Exposing mapaxes May 15, 2017
@markusdregi markusdregi changed the title WIP: Exposing mapaxes Exposing mapaxes May 16, 2017

sdim = tuple([b-a+1 for a,b in ijk_bounds])
sub_coord, sub_zcorn, sub_actnum = sub_data

return EclGrid.create(sdim, sub_zcorn, sub_coord, sub_actnum)
return EclGrid.create(sdim, sub_zcorn, sub_coord, sub_actnum, mapaxes)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use named keyword: ..., mapaxes=mapaxes)

Copy link
Contributor

@pgdr pgdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@markusdregi markusdregi merged commit 755dadc into equinor:master May 16, 2017
@markusdregi markusdregi deleted the expose_mapaxes branch May 16, 2017 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants