Adding log level enums and a simplified log function #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epa095
commented
May 30, 2017
libert_util/include/ert/util/log.h
Outdated
| @@ -26,12 +26,23 @@ extern "C" { | |||
| #include <stdbool.h> | |||
| #include <stdlib.h> | |||
|
|
|||
| //Same as pythons default log levels, with numeric values equal to python / 10. | |||
There was a problem hiding this comment.
I set them to python/10 to keep a bit of compability with the old levels, which is not defined anywhere, but it seems like 1 is used a lot, and that is also the default level. I am not able to see far enough in to the future to determine if it is better to change those and standarize on the same numeric values as python uses.
epa095
commented
May 30, 2017
libert_util/src/log.c
Outdated
| @@ -128,6 +128,17 @@ bool log_include_message(const log_type *logh , int message_level) { | |||
| return false; | |||
| } | |||
|
|
|||
| /** | |||
| * Adds a string to the log if message_level is below the threshold | |||
| * @param logh The log to add to | |||
There was a problem hiding this comment.
My IDE adds this doxygen formating, but I see that they are not present elsewhere in the code.
There was a problem hiding this comment.
No - and they are dang ugly :-)
joakim-hove
approved these changes
May 30, 2017
epa095
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the function:
void log_add_message_str(log_type logh, message_level_type message_level , const char message);
which does not take in a dup_stream or a flag for freeing (it will not free the message as it is const)