Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FrequencyIterator doesn't decrease the frequency of current #4

Closed
adam-arold opened this issue Feb 2, 2020 · 5 comments
Closed

FrequencyIterator doesn't decrease the frequency of current #4

adam-arold opened this issue Feb 2, 2020 · 5 comments
Assignees

Comments

@adam-arold
Copy link

By looking at the implementation I can see that current is never assigned, and when remove is called on the Iterator null is passed to decreaseFrequencyOf.

@HendrixString
Copy link
Member

@adam-arold
Hey Adam, I ended up not using this class and can't remember why.
I never tested the iterator and you are correct, current is never updated
and it should.

you are most welcome to propose a patch.

also, I guess you were looking for iterators examples, you can find examples
in the graph classes

@adam-arold
Copy link
Author

I'm doing a port of Erdos to Kotlin right now and I noticed this problem. If it turns out that the class is unused I'll just delete it. :)

@HendrixString
Copy link
Member

@adam-arold
it would be great if you could commit your kotlin work
as a new repository of Erdos-Graph-Framework organization
and of course become a member with write access etc..

@adam-arold
Copy link
Author

adam-arold commented Feb 4, 2020

I can add it as a remote if you want. I'm going to mention in the docs that it started out as a port of Erdos.

@HendrixString
Copy link
Member

cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants