Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question about get_rifke(positions) function? #97

Open
li-haoran opened this issue Oct 16, 2023 · 2 comments
Open

question about get_rifke(positions) function? #97

li-haoran opened this issue Oct 16, 2023 · 2 comments

Comments

@li-haoran
Copy link

 def get_rifke(positions):
        '''Local pose'''
        positions[..., 0] -= positions[:, 0:1, 0]
        positions[..., 2] -= positions[:, 0:1, 2]
        '''All pose face Z+'''
        positions = qrot_np(np.repeat(r_rot[:, None], positions.shape[1], axis=1), positions)
        return positions 

This function disentangles the global rotations and local rotation/position/velocity.

I plot the pose 0 (red) and pose 10(green) before and after the function. The blue line means the facing direction.
This is pose[0] and pose[10] before the function:
image
and this is the visulization after the function:
image
The function align the root center to zeros and align the facing direction to Z+, but the facing direction is not parallel the Z+ strictly for the rest poses like pose[10] except the pose[0]?

I didn't figure out why?

@EricGuo5513
Copy link
Owner

Hi, I am also not so sure why it's not strictly z+. Is it a common or casual case?

@roey1rg
Copy link

roey1rg commented May 23, 2024

Shouldn't the inverse of r_rot be used to obtain the local positions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants