Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"WARNING! Could not find source with name" [...] When App language is changed #75

Open
mxgross opened this issue Jul 21, 2016 · 1 comment

Comments

@mxgross
Copy link

mxgross commented Jul 21, 2016

Hey,

when I change my App language from 'EN' to e.g. 'DE' the camera source names are not 'Front camera" and 'Back Camera', but now 'Frontkamera' and 'Rückkamera'.

This will lead to an error like: '[OpenWebRTCNativeHandler] WARNING! Could not find source with name Back Camera'.
Because the source name is in german but expected in english.

So I want to change the ' got_local_sources(GList *sources)' method in 'OpenWebRTCNativeHandler' to use some kind of ID for the camera sources or anything other instead of the localized name string.

How can I achieve that?

Thanks

@mxgross
Copy link
Author

mxgross commented Jul 21, 2016

There are a few lines where the camera name is hardcoded! So they must be fixed with the localized camera name value.

E.g. at static gchar *expectedCameraName = "Back Camera"; in OpenWebRTCNativeHandler.m.

I did not solved it yet, because there are encoding problems with non-latin characters in the camera name value. So I will try to hash the string do avoid this.

I will still leave this issue open, because this hard coded camera names should still be changed to some kind of ID or cameraPosition value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant