Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit.php does not consider diff charset condition #59

Closed
windk opened this issue Oct 11, 2014 · 3 comments
Closed

edit.php does not consider diff charset condition #59

windk opened this issue Oct 11, 2014 · 3 comments

Comments

@windk
Copy link

windk commented Oct 11, 2014

in view.php:158 file
When we output the value, we use functions below

format_html($hkey, $server['charset'])

and in edit.php use nothing

That will cause different muss when the server charset is not utf-8.

not only in edit.php file's display logic , but also edit logic

@erikdubbelboer
Copy link
Owner

In edit.php we use format_html everywhere as well?

@windk
Copy link
Author

windk commented Oct 13, 2014

@erikdubbelboer but without the second parameters.
in view.php use this:

format_html($value)

in edit.php use this:

format_html($hkey, $server['charset'])

Without the second parameter, output will not convert encoding.

erikdubbelboer added a commit that referenced this issue Oct 13, 2014
@erikdubbelboer
Copy link
Owner

I just pushed a commit which should fix the whole character encoding issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants