Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convertToTriangles documentation is confusing #1

Open
gregtatum opened this issue Jan 24, 2017 · 2 comments
Open

convertToTriangles documentation is confusing #1

gregtatum opened this issue Jan 24, 2017 · 2 comments

Comments

@gregtatum
Copy link

For what it's worth, I found it very confusing that convertToTriangles was true by default. I spent a good half an hour debugging my code before I realized that. I think a less confusing function signature would be function catmullClark(positions, cells, numSubdivisions[, keepAsQuads]). I assumed incorrectly that undefined would be falsey.

@Erkaman
Copy link
Owner

Erkaman commented Jan 24, 2017

Yeah, sorry about that. I will try to look at this in the weekend.

@gregtatum
Copy link
Author

No worries, it worked like a charm once I figured it out! Thanks for publishing this module, it's really handy: http://sessions.gregtatum.com/013/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants