Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get additional github administration rights for bugtracker #41

Closed
Erkan-Yilmaz opened this issue Jan 22, 2017 · 4 comments
Closed

get additional github administration rights for bugtracker #41

Erkan-Yilmaz opened this issue Jan 22, 2017 · 4 comments

Comments

@Erkan-Yilmaz
Copy link
Owner

Erkan-Yilmaz commented Jan 22, 2017

  • so easy pull requests (typos) could be merged into the code
  • more difficult PRs should still require a certain procedure:
    • tested on these OS (windows, linux, ...) ?
    • done these, agreed on, test cases ?
    • and also test cases which are relevant for the changed code parts ?
    • unit tests were added ?
    • ...
  • who should get the additional flag ?

see @denravonska 's comment here

assigning to @grctest

@grctest
Copy link

grctest commented Jan 22, 2017

It should be assigned to @gridcoin because he's the only one who can change this.

@denravonska
Copy link

denravonska commented Jan 22, 2017

Just to reiterate what I said/wanted to say at the hangout.

Push privileges require a good bit of trust, especially for these kind of applications. As an alternative we could have a couple of trusted developers who can take the first code reviews. When the PRs have passed those developers Rob can have a final look and do the merge. Eventually some of those developers could have gained enough trust to get push privileges but for now it's a good middle ground.

I also agree about using a development branch for continuous development and PRs instead of pushing everything into master.

@grctest
Copy link

grctest commented Jan 27, 2017

https://cryptocointalk.com/topic/52186-gridcoin-community-development-process-idea/#entry232500

We've created a gridcoin-community organization, where we can explore improved github workflow.

What tools should we directly integrate into the org or repos?

@grctest
Copy link

grctest commented Jan 30, 2017

Closed because we've created the gridcoin-community repo to gain these permissions. I'll create an additional issue regarding the integration of tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants