Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump codecov-action version to v2 (v1 is deprecated) and try fixing PR checks #20

Merged
merged 2 commits into from Oct 24, 2021

Conversation

NotErnWong
Copy link

GitHub secrets are not available during PR checks, and the codecov token is documented to be not needed for public repos (although I had difficulty getting it to work without a token last time).

codecov-action v1 is deprecated and will be removed in February 2022.

Testing this PR on a different account to check to see if the test-coverage check works now (see #11).

Risk Areas:

  • Low risk on the build Pipeline.

@codecov-commenter
Copy link

Codecov Report

Merging #20 (dc99ad6) into master (c40731e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #20   +/-   ##
=======================================
  Coverage   75.05%   75.05%           
=======================================
  Files          15       15           
  Lines         846      846           
=======================================
  Hits          635      635           
  Misses        211      211           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c40731e...dc99ad6. Read the comment docs.

Copy link
Owner

@ErnWong ErnWong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The test-coverage seems to now pass even within PRs of forks, and the codecov-commenter bot seems to be working.
  • Verified that the workflow file that initiated this PR's check uses codecov-action@v2 and does not use a secret token.
  • Secret token has been deleted from this GitHub repo. This hopefully won't affect the existing forks since they won't have access to the secret anyway.

@ErnWong ErnWong linked an issue Oct 24, 2021 that may be closed by this pull request
@ErnWong ErnWong merged commit 69b3050 into ErnWong:master Oct 24, 2021
@NotErnWong NotErnWong deleted the codecov-update branch October 24, 2021 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix test-coverage checks for PRs
3 participants