Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to bevy 0.7 #27

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update to bevy 0.7 #27

wants to merge 4 commits into from

Conversation

ErnWong
Copy link
Owner

@ErnWong ErnWong commented Jan 23, 2022

Fixes #26

Remaining tasks: Add an in-tree example that uses crystalorb-bevy-networking-turbulence crate to test that it still works.

@ErnWong ErnWong changed the title Maintenance/update bevy 0.6 Update to bevy 0.6 Jan 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2022

Codecov Report

Merging #27 (4b5a54d) into master (b49cf55) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
- Coverage   77.53%   77.51%   -0.03%     
==========================================
  Files          15       15              
  Lines         837      836       -1     
==========================================
- Hits          649      648       -1     
  Misses        188      188              
Impacted Files Coverage Δ
src/clocksync.rs 85.48% <0.00%> (-0.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b49cf55...4b5a54d. Read the comment docs.

@ErnWong
Copy link
Owner Author

ErnWong commented Jan 28, 2022

Also todo: upgrade wasm bindgen version to fix clippy errors with the demo. Making it part of this pr as it seems like it makes sense to bundle with the rust edition upgrade.

@ErnWong
Copy link
Owner Author

ErnWong commented Feb 12, 2022

Tested using https://github.com/vilcans/orbgame and it seems to work.

Since we are looking to replace our bevy plugin with one that has better bevy integration (#14), I probably won't add a playable bevy example for crystalorb-bevy-networking-turbulence into this repo. (There's already a short compilable example in that crate's readme, but that's not technically playable).

Once the next version of CrystalOrb gets released with this changes, I might make a PR for orbgame with those changes I used to test this PR.

@ErnWong
Copy link
Owner Author

ErnWong commented Apr 15, 2022

Oh rip, I'm too slow. Bevy 0.7 is already out. https://bevyengine.org/news/bevy-0-7/

@ErnWong ErnWong changed the title Update to bevy 0.6 Update to bevy 0.7 Apr 15, 2022
@Shatur
Copy link
Contributor

Shatur commented Apr 20, 2022

BTW, https://github.com/smokku/bevy_networking_turbulence is unmaintained. I would suggest to consider using https://github.com/lucaspoffo/renet instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bevy 0.7
3 participants