Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add social login #8

Closed
ernestofgonzalez opened this issue Jan 14, 2023 · 4 comments · Fixed by #27
Closed

Add social login #8

ernestofgonzalez opened this issue Jan 14, 2023 · 4 comments · Fixed by #27
Assignees

Comments

@ernestofgonzalez
Copy link
Owner

No description provided.

@ernestofgonzalez ernestofgonzalez self-assigned this Jan 24, 2023
@ernestofgonzalez
Copy link
Owner Author

A super fast way of doing this is integrating django-allauth, but one thing I want to continue doing is using function based views (see Django Views - The right Way). Plus I think it will be fun to try to implement it myself.

@ernestofgonzalez
Copy link
Owner Author

I'll start by adding support for login with Google, since it's the more common one.

@ernestofgonzalez
Copy link
Owner Author

Actually, I changed my mind. I'm going ahead with django-allauth, but I'm not going to use its views.

@ernestofgonzalez ernestofgonzalez linked a pull request Jan 24, 2023 that will close this issue
@ernestofgonzalez
Copy link
Owner Author

Apparently django-allauth does not provide an API to integrate social auth without using their views. I could plug in some of their providers, but it defeats the purpose.

I'm using Sign in with Google for Google. Since this is a SaaS-oriented boilerplate, the more common social auth would be Google, GitHub and maybe Twitter.

For now, only Google will be supported, and if in the future we decide to add GitHub and Twitter, the necessary work to do it will be larger than if we just stick with django-allauth, but still neglectable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant