New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: exports GraphQLArmorConfig type globally #313
fix: exports GraphQLArmorConfig type globally #313
Conversation
🦋 Changeset detectedLatest commit: 605ff34 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportBase: 91.90% // Head: 91.90% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #313 +/- ##
=======================================
Coverage 91.90% 91.90%
=======================================
Files 17 17
Lines 284 284
Branches 69 69
=======================================
Hits 261 261
Misses 23 23 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
looks nice, I think we could even move configuration into the types package. |
Oh, so no Imagine this would be a major bump rather than minor. And then to use
? |
I tried to make that change ti move all into types. I haven't looked to see if this requires any documentation changes yet. If this move is what you are looking for, then I'll check for docs. |
Also, should these docs https://escape.tech/graphql-armor/docs/api/types be updated to reflect the additional exported types? I think so and will update. |
Added docs for config types. |
Minor bump should fit, this type shouldn't be used as it is not exported. |
6bd4199
to
605ff34
Compare
Hey @dthyresson ! I updated the internal type usage to depend of the types package. Thanks a lot for updating the documentation accordingly. Any additional changes in mind? |
Glad to!
Not for this PR. Merging and then will use latest package in RedwoodJS in redwoodjs/redwood#7291 Edit: I forgot. I can't merge :) |
This PR fixes/improves the way one can use the GraphQLArmorConfig type by exporting it globally.
Prior to this PR, if you wanted to use the type, one would have to import it this way:
Notice that the import uses the
dist
.Now, one should be able to
Since
is exported globally.
A quick sanity test was added to ensure the export exists at the global/index level.