Skip to content
This repository has been archived by the owner on Mar 9, 2021. It is now read-only.

Where is the terraformer-arcgis-parser.min.js CDN? #245

Closed
alaframboise opened this issue Jul 25, 2014 · 7 comments
Closed

Where is the terraformer-arcgis-parser.min.js CDN? #245

alaframboise opened this issue Jul 25, 2014 · 7 comments

Comments

@alaframboise
Copy link
Contributor

The first exists but the second doesn't.

<script src="http://cdn-geoweb.s3.amazonaws.com/terraformer/1.0.4/terraformer.min.js"></script>
<script src="http://cdn-geoweb.s3.amazonaws.com/terraformer/1.0.4/terraformer-arcgis-parser.min.js"></script>
@geospatialem
Copy link
Member

Agreed. I spent way too much time trying to even find the terraformer-arcgis-parser.min.js file in the repo.

I ended up finding it in an example after some searching. While a CDN is nice, I think this should be added into the repo at the very least.

@jgravois
Copy link
Collaborator

the parser source code can be found in Esri/terraformer-arcgis-parser

@geospatialem what sort of breadcrumb would have been helpful to lead you there? it'd be really easy to clarify the location of the source code in the main README.md here.

@geospatialem
Copy link
Member

@jgravois I'm getting a 404 page error on my end, is this the link you were trying to get to?

For clarity, I think changes are needed to both the README.md and Terraformer Getting Started page.

Below are some potential recommendations:

For the README.md:

Getting Started (Browser):

//Terraformer Library (Required)
//Learn more: https://github.com/Esri/Terraformer
<script src="http://cdn-geoweb.s3.amazonaws.com/terraformer/1.0.4/terraformer.min.js"></script>

//Terraformer Packages (Optional)
//ArcGIS Parser: https://github.com/Esri/terraformer-arcgis-parser
//WKT Parser: <GitHub link here>
//GeoStore: <GitHub link here>
<script src="terraformer-arcgis-parser.min.js"></script> //Define ArcGIS Parser package
<script src="terraformer-wkt-parser.min.js"></script> //Define WKT Parser package
<script src="terraformer-geostore.min.js"></script> //Define GeoStore package

For the Getting Started Page:

Currently the packages are listed above the browser option, and lead to a new page. Instead it might be beneficial to list the options together. For example:

Browser

To use the Terraformer library, you must include the core Terraformer library with a <script> tag.

If you would like to utilize any of the Terraformer packages: ArcGIS parser, WKT parser, or GeoStore, you must include the library with a <script> tag in addition to the Terraformer library.

//Terraformer Library (Required)
//Learn more: https://github.com/Esri/Terraformer
<script src="http://cdn-geoweb.s3.amazonaws.com/terraformer/1.0.4/terraformer.min.js"></script>

//Terraformer Packages (Optional)
//ArcGIS Parser: https://github.com/Esri/terraformer-arcgis-parser
//WKT Parser: <GitHub link here>
//GeoStore: <GitHub link here>
<script src="terraformer-arcgis-parser.min.js"></script> //Define ArcGIS Parser package
<script src="terraformer-wkt-parser.min.js"></script> //Define WKT Parser package
<script src="terraformer-geostore.min.js"></script> //Define GeoStore package

@jgravois
Copy link
Collaborator

would you be game to submit a pull request with these great suggestions? building the site locally is fairly straightforward if you have ruby installed.

  1. cd into the Terraformer repository
  2. run npm install to lay down the node dependencies
  3. gem install to lay down ruby dependencies
  4. run grunt middleman:build to write the compile the static site in a new docs-build folder
  5. run the index.html in your browser (using your web server of choice to host over http)

if you can't be bothered, i'll try to get to it soon myself.

@geospatialem
Copy link
Member

For sure, I'll try and give it a go this evening. Unfortunately I don't have access to many of those dependencies at work. I'll let you know if I hit any hiccups.

@jgravois
Copy link
Collaborator

awesome! i am happy to help you troubleshoot if you get stuck.

@jgravois
Copy link
Collaborator

jgravois commented Feb 18, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants