Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding PSETAE guide #1403

Merged
merged 6 commits into from Jan 6, 2023
Merged

adding PSETAE guide #1403

merged 6 commits into from Jan 6, 2023

Conversation

sdash77
Copy link
Collaborator

@sdash77 sdash77 commented Dec 21, 2022

Checklist

Please go through each entry in the below checklist and mark an 'X' if that condition has been met. Every entry should be marked with an 'X' to be get the Pull Request approved.

  • All imports are in the first cell?
    • First block of imports are standard libraries
    • Second block are 3rd party libraries
    • Third block are all arcgis imports? Note that in some cases, for samples, it is a good idea to keep the imports next to where they are used, particularly for uncommonly used features that we want to highlight.
  • All GIS object instantiations are one of the following?
    • gis = GIS()
    • gis = GIS('home') or gis = GIS('pro')
    • gis = GIS(profile="your_online_portal")
    • gis = GIS(profile="your_enterprise_portal")
  • If this notebook requires setup or teardown, did you add the appropriate code to ./misc/setup.py and/or ./misc/teardown.py?
  • If this notebook references any portal items that need to be staged on AGOL/Python API playground, did you coordinate with a Python API team member to stage the item the correct way with the api_data_owner user?
  • If the notebook requires working with local data (such as CSV, FGDB, SHP, Raster files), upload the files as items to the Geosaurus Online Org using api_data_owner account and change the notebook to first download and unpack the files.
  • Code simplified & split out across multiple cells, useful comments?
  • Consistent voice/tense/narrative style? Thoroughly checked for typos?
  • All images used like <img src="base64str_here"> instead of <img src="https://some.url">? All map widgets contain a static image preview? (Call mapview_inst.take_screenshot() to do so)
  • All file paths are constructed in an OS-agnostic fashion with os.path.join()? (Instead of r"\foo\bar", os.path.join(os.path.sep, "foo", "bar"), etc.)
  • Is your code formatted using Jupyter Black? You can use Jupyter Black to format your code in the notebook.
  • IF YOU WANT THIS SAMPLE TO BE DISPLAYED ON THE DEVELOPERS.ARCGIS.COM WEBSITE, ping @ mohi9282 so he can add it to the list for the next deploy

doc commit 1
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

multi-dimensional info update
@review-notebook-app
Copy link

review-notebook-app bot commented Dec 28, 2022

View / edit / reply to this conversation on ReviewNB

KarthikDutt commented on 2022-12-28T10:15:37Z
----------------------------------------------------------------

Rewording of first sentence is needed.


sdash77 commented on 2022-12-29T06:06:32Z
----------------------------------------------------------------

Earth observation data cube or time-series is referred to as collection of satellite images of a location from different time-periods, stacked vertically resulting in a 3-dimensional structure.

is this good?

@review-notebook-app
Copy link

review-notebook-app bot commented Dec 28, 2022

View / edit / reply to this conversation on ReviewNB

KarthikDutt commented on 2022-12-28T10:15:38Z
----------------------------------------------------------------

Pixels are labelled with class based on the available information ->

Pixels are labelled into different classes, based on the available information

The sentence below needs to be reworded:

As shown in figure are labelling of different crop types.


sdash77 commented on 2022-12-29T06:10:08Z
----------------------------------------------------------------

Labelling of different crop types are shown in the figure.  is this good?

@review-notebook-app
Copy link

review-notebook-app bot commented Dec 28, 2022

View / edit / reply to this conversation on ReviewNB

KarthikDutt commented on 2022-12-28T10:15:39Z
----------------------------------------------------------------

pse-tae -> PSETAE


@review-notebook-app
Copy link

review-notebook-app bot commented Dec 28, 2022

View / edit / reply to this conversation on ReviewNB

KarthikDutt commented on 2022-12-28T10:15:40Z
----------------------------------------------------------------

convolution operations may not be suitable for detection the various classes ->

convolution operations may not be suitable for the detection of the various classes

PSE uses the samples pixels -> PSE uses a sample set of pixels

This results in the architecture learning about the statistical descriptors of the particular class pixel's spectral distribution. ->

This allows the architecture to learn about the statistical descriptors of a particular class's pixel's spectral distribution.


@review-notebook-app
Copy link

review-notebook-app bot commented Dec 28, 2022

View / edit / reply to this conversation on ReviewNB

KarthikDutt commented on 2022-12-28T10:15:41Z
----------------------------------------------------------------

  • Please rephrase this sentence.

As the goal was to encode the whole time-series into single embedding, rather then output for each element of sequence. Query tensors generated by the each attention heads are pooled into single master query.


sdash77 commented on 2022-12-29T10:00:25Z
----------------------------------------------------------------

As the goal was to encode the whole time-series into single embedding, rather then output for each element of sequence. Hence, Query tensors generated by the each attention heads are pooled into single master query.

is it good?

KarthikDutt commented on 2023-01-02T06:51:06Z
----------------------------------------------------------------

I have reworded it. Please see if this works:

The goal is to encode the whole time-series into single embedding, rather then generate one for each element of sequence. To achieve this, query tensors generated by the each attention heads are pooled into single master query.

@review-notebook-app
Copy link

review-notebook-app bot commented Dec 28, 2022

View / edit / reply to this conversation on ReviewNB

KarthikDutt commented on 2022-12-28T10:15:42Z
----------------------------------------------------------------

Shared PSE embeds all input time-series rasters in parallel and resulting embedded sequence is processed by temporal encoder. ->

Shared PSE embeds all input time-series rasters in parallel and the resulting embedded sequence is processed by temporal encoder.

For further information on the model's architecture, refer to paper. -> Add a link to the paper


@review-notebook-app
Copy link

review-notebook-app bot commented Dec 28, 2022

View / edit / reply to this conversation on ReviewNB

KarthikDutt commented on 2022-12-28T10:15:43Z
----------------------------------------------------------------

n_temporal_dates - optional for multi-dimensional, required for composite raster. The dates of the observations will be used for the positional encoding and should be stored as a list of dates strings in YYYY-MM-DD format ->

n_temporal_dates - optional for multi-dimensional, required for composite raster. The dates of the observations will be used for the positional encoding and should be stored as a list of date strings in YYYY-MM-DD format.


@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

KarthikDutt commented on 2022-12-28T10:15:43Z
----------------------------------------------------------------

Here data is the object returned from prepare_data function

Add to data format it the same way you have formated prepare_data

For more information about the API & modify model's keyword arguments, please go to the API reference.

What is modify model?

Than, the basic arcgis.learn workflow can be followed.

Users may not be aware of what 'basic' arcgis.learn workflow is. Hyperlink it any document or explain the workflow very briefly.


@review-notebook-app
Copy link

review-notebook-app bot commented Dec 28, 2022

View / edit / reply to this conversation on ReviewNB

KarthikDutt commented on 2022-12-28T10:15:44Z
----------------------------------------------------------------

You can remove the summary section as it is not conveying anything extra.


Copy link
Collaborator Author

sdash77 commented Dec 29, 2022

Earth observation data cube or time-series is referred to as collection of satellite images of a location from different time-periods, stacked vertically resulting in a 3-dimensional structure.

is this good?


View entire conversation on ReviewNB

Copy link
Collaborator Author

sdash77 commented Dec 29, 2022

Labelling of different crop types are shown in the figure.  is this good?


View entire conversation on ReviewNB

Copy link
Collaborator Author

sdash77 commented Dec 29, 2022

As the goal was to encode the whole time-series into single embedding, rather then output for each element of sequence. Hence, Query tensors generated by the each attention heads are pooled into single master query.

is it good?


View entire conversation on ReviewNB

@priyankatuteja priyankatuteja added the changes requested remove this label after addressing reviewer comments label Dec 30, 2022
Copy link
Collaborator

I have reworded it. Please see if this works:

The goal is to encode the whole time-series into single embedding, rather then generate one for each element of sequence. To achieve this, query tensors generated by the each attention heads are pooled into single master query.


View entire conversation on ReviewNB

@review-notebook-app
Copy link

review-notebook-app bot commented Jan 2, 2023

View / edit / reply to this conversation on ReviewNB

KarthikDutt commented on 2023-01-02T06:53:46Z
----------------------------------------------------------------

The collection have a common projection and a consistent timeline ->

The collection has a common projection and a consistent timeline


@priyankatuteja priyankatuteja added approved PR approved by reviewer and removed changes requested remove this label after addressing reviewer comments labels Jan 6, 2023
@priyankatuteja priyankatuteja merged commit 6af5ad1 into Esri:next Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR approved by reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants