Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createItem documentation sample #283

Closed
gavinr opened this issue Aug 16, 2018 · 4 comments
Closed

createItem documentation sample #283

gavinr opened this issue Aug 16, 2018 · 4 comments

Comments

@gavinr
Copy link
Contributor

gavinr commented Aug 16, 2018

This line should ready type: "Web Map" not type: "Webmap"

https://github.com/gavinr/arcgis-rest-js/blob/e42f3eefbb46943c400da0e4e4b96b64e38508e5/packages/arcgis-rest-items/src/items.ts#L186
@jgravois
Copy link
Contributor

nice catch! a PR with the fix would be most appreciated.

@jgravois
Copy link
Contributor

bonus points if you can tackle the typo @tomwayson noticed in #281 (comment) at the same time. 😉

@gavinr
Copy link
Contributor Author

gavinr commented Aug 16, 2018

yep, working on it. will take a look at tom's issue too. thanks

@gavinr gavinr mentioned this issue Aug 17, 2018
Merged
@jgravois
Copy link
Contributor

resolved via #287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gavinr @jgravois