All independently run samples have high DPI scaling enabled. #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesMBallard
pushed a commit
that referenced
this pull request
Apr 9, 2019
* Use QColor constant values instead * fixing formatting issues * updating change basemap sample * adding error check (#763) * Fixed selection crash in ListRelatedFeatures. Fixed crash when selecting one feature then another. This crashed manifested as connections to generated objects were not removed early enough. Parent objects were not deleted along with their children. * Fixed ListRelatedFeatures crash. Conceptual relationship model had issues. Duplicate connections were made to the same table for each layer. One connection would clean up the contents, and the remaining connections would attempt to act upon the corrputed memory. * Improved code health. Removed superfluous loops. * Making local variables more const-correct. * Minor changes for GeoElement base class updates. (#766) * Callouts now correctly parented. * Update Linux base PPI for scaleFactor * Added the new Overrides OfflineMaps sample. Initial C++ sample added. * remove unused capture of "this" in lambda (#769) * Added QML version of the Offline Overrides. * Added QML version of offline overrides. * Added additional 'busy' spinners to let user know that an action is processing. * Updated screenshots. * Update README.md Updated screenshot extension. * Update README.md Updated screenshot extension. * Fixed missing files from json files. * Updated with code review comments. Fixed issues in JSON. * Updated with code review comments. * Fix build errors and warnings (#771) * Updated http to https. As of Android level 28, plain http links can no longer be accessed from an app. All http resources have been upgraded to https. * Reverted samples that are not https compatible. * Updated PortalItem to new, working portal. * Initial commit of Cpp Kml Network links implementation. * Updated screenshots to reflect new resource. * Initial commit of the QML KML network sample. * Added some commenting. KML messages now appear in message box for cpp * Ldanzinger/display kml (#773) * initial commit * setting width and viewpoint * adding offline data * updating destructor * add missing import * Improved sample screenshots. * Added button to view to show last message recieved. Updated README with inclusion of button. * Improved KML commenting slightly. * Fixed wrong import number used. Incompatible with Qt 5.9 * Updated with code review comments. Improve the message button. * Removed unecessary data-items from json. * Update README.md Use Qt lingo for Url. * Update README.md Use Qt lingo for Url. * Fixing casing for case-sensitive platforms and consistency * Fix build error * Updated the KML Network Links README. * Corrected spelling mistakes. * Corrected inaccurate information. * Superfluous imports in MessageButton.qml. C++ Qt API cannot import ARcGISRuntime. * Updated Staten tile layers to use a https service. * Updated Style WMS layer to a new service. Updated the radio buttons to more accurate names. * Updated all QtQUick controls to 2.2 * Fixed calendar and crash * Fixed issue where CPP map crashed on startup. * Updated Analyze Hotspots to QtQuick2 calendar system. * Updated slider property names to quickcontrols2. * Resolved bad pointer crashes in DisplayGrid. * Fixed issues with EditFeatureAttachments * Removed uneeded message-dialog which was casuing issues * Updated to QtLabs filedialog * Used QApplication to for QtLabs dialog on desktop * Created QMLEngine for QtLabs filedialog * Removed Fileinfo to remove ArcGISExtras requirement. * Fixed stand-alone application not working due to missing registrations. * Updated Densify and Generalize slider to update quickcontrols. * Fixed issues caused by layout alignment of text and text fields. * DisplayGrid sample no longer uses QProperty to write to data. * Updated Spatial Operations to have a MapView property to prevent access-to-nullptr crash. Updated all Sliders and SpinBoxes to used from/to syntax instead of minValue/maxValue. * Updated the CPP and QML RasterLyaerFile sample to use the QtLabs version of the FileDialog. * RasterRgbRenderer now working for double values. * StyleWMSLayer Radio button exclusitiving fixed. * Fixed nulltpr access crashes in VectorTiledLayerUrl and CHangeViewpoint samples. * DrawStatusModel no longer based on deprectated TableView but now on a ListView with two different roles to render. * Removed deprecated styling on map rotation controls. * Fixed crash caused by FeatureLayerExtrusions. * Removed deprectated stylings from Terrain Exagerration slider. * Removed deprecated styling from FindAddress search-bar. * Removed deprecated OfflineGeocode stylings from search bar. * Symbol style sample issues fixed. Rendering issues remain. * Fixed broken styling of SearchDictionarySymbolStyle sample. * Fixed ComboBox size of ChangeBasemap and ChangeViewpoint samples. Removed references to scaleFactor. * Improving quality of Animate3D sample. * Fixed CloudAndPortal QML issue. Fixed sizing issue of Comboboxes on Windows for CHangeViewpoint and Changebasemap. Removed hard-coded pixel values used for DisplayLayerViewDrawStatus. * DisplayLayerViewDrawStatus now resizes to child contents. * ManageBookmarks sample 'Add bookmark' dialog now works as intended. * LOcalServer Geoprocessing sample now works. * QML SampleViewer AnalyzeHotspots now working. * Update README.md * QML Sample Viewer DisplayGrid no longer has rendering issues. * QML SampleViewer EditFeatureAttachments now uses QuickControls 2 File dialog. * QML SampleViewer FormatCoordinates now working as expected. * QML sample RasterRgbRenderer now uses a double spinbox. * QML sample StyleWmsLayer exclusive radio buttons fixed. * QML sample DisplayLayerViewDrawStatus is once again working with removal of TableView. * QML MapRoation slider now working once again. * Fixed sizing issue with QML ServiceArea Combobox. * QML Sample elevation exagerration now working as expected. * QML and C++ FindAddress search-bars now render as expected. * QML Sample OfflineGeocode renders again. * QML Search Dictionary Symbol Style sample is rendering once again. * QML Sample Manage Bookmarks now renders ComboBoxes correctly. * QML sample ChangeBasemap now has a combobox that sizes to the model. Setting basemap now muhc cleaner. * QML Sample Change Viewpoint now scales combobox to contents. * Update ArcGISRuntimeSDKQt_CppSamples/Analysis/AnalyzeHotspots/AnalyzeHotspots.qml Co-Authored-By: anmacdonald <NMacDonald@esri.com> * Update README.md * Applied code review changed. * Scale factor now set to 1. * Renamed DisplayLayerViewDrawStatus to DisplayLayerViewDrawState. * Corrected HEADER case. * Animate3D sample now working once again. * Updated with additional cod review comments. Pointers now implicitly cast to bool where applicable. Removed svg files and replaced with png for android support. * Removed deprectated QML library import: QtQuick.Controls.Styles. * Removed all MessageDialogs and replaced with QuickControls 2 generic dialogs. Used Qtlabs FileDialogs for certain Local Server samples. * Fixed certain message dialogs in QML. Fixed binding loop in OfflineGeocode on Windows. * Reduced size of bookmarks button. * Removed NativeRendering line from Text to prevent pixelated text on mobile platforms. * More native rendering lines removed. * Replaced old QtDialogs ColorDialog with custom Color dialog using QuickControls 2. * Update ArcGISRuntimeSDKQt_CppSamples/Maps/ChangeBasemap/ChangeBasemap.qml Co-Authored-By: anmacdonald <42203545+anmacdonald@users.noreply.github.com> * Updated with code review comments. Fixed dialog box sizing issue in the Update Attribute Feature Services Sample. Fixed anchor/layout warnings given in OfflineGeocode sample. * Style WMS layer updated to a HTTPS url for QML. * Created a BuildLegend sample for the widget samples. * UI properties min width and height is now part of the ui file. * Update README.md Removed parts not relevant to Qt widgets. * Ui object not initialized with nullptr. Move ResultProxy method body out-of-line to disable clang vtable warnings. * Updated screenshots of StyleWMSLayer to reflect the new data sources. * The Create another map button in 'Create and Save Map' was attempting to push objects onto the stack cleaned up by the garbage collector. * CreateAndSaveMap 'Create New Map' Button now works or QML sample. * Downgraded QuickControls from Qt 5.11 to Qt 5.9. * Combo-box was triggering previous selection. Part of the QML QuickControls-2 upgrade looks like there is some delay between the currentTextChanged and currentIndexChanged signals in a combo-box. Functions were reading old cached values from Comboboxes as opposed to the correct values. * downgrading import * Combo boxes now resize to the text width of the largest potential model contents they hold. * Changed property and width ordering in the QML to match nominal ordering elsewhere. * fixing index issue * fixing size issues * explicitly calling signal * cleaning up scale factor * Reverted bug introduced by quickcontrols2 upgrade. * James/v.next/100.5 version update (#795) * Version update pass 1. * More updates. * Removed wasted vertical and horizontal width from the Animate3D symbols UI. Text now more readable. * Created labelled slider to improve look of Animate3D. * Changed Stay text to Fixed, update Angle slider to show the angle. * Updated README and Screenshot. * Updated LabeledSlider to American spelling. * EditFeatureAttachments now working (#805) * EditFeatureAttachments not working due to missing ArcGISExtras. * Added removed snippet comment line. FileDialog for EditFeatureAttachments now opens native picture dialog on mac. * All independently run samples have high DPI scaling enabled. (#806) * RasterRgbRenderer sample now orient itself to fit within a portrait display. (#807) * FormatCoordinates no longer inherits from a QtQuickItem. (#808) * FormatCoordinates no longer inherits from a QtQuickItem. * Updated FormatCoordiantes based on code-review comments. Cleaned up code to be more readable. * Created QML and CPP samples 'Sync MapView and SceneView.' * Fixed issues with brackets on newlines in QML. * Created ChangeAtmosphereEffect sample for C++ and QML. * Updated with code review comments. * Added heading to the button dialogs. Updated screenshot to match UI tweaks. * Update SyncMapViewSceneView.json * Update SyncMapViewSceneView.json * Changed 'others' to 'other.' * Atmosphere effect README enum order (#813) * Update README.md Fixed wrong order of enums in README description. * Update README.md Updated enum order in atmosphere effect README. * Line of sight geoelement sample created. * Updated screenshot and README. * Update README.md * Update README.md * Renamed Geoelement to GeoElement. * Mass rename Geoelement GeoElement. * Updated with code review comments. * Updated with README comments. * Edited QML readme. * Included missing import for mac. * Samples data and sample viewer path fix. (#816) * Fixed incompatibility on devices as to where data is stored by sample viewer and picked up by sample. * Updated with code review comments. * Added background box to slider to improve visibility. * adding element to allow box to resize (#818) * Q_ENUMS -> Q_ENUM (#819) * updating anchoring so the delegate content displays in the vertical center and doesn't get cut off (#820) * initial commit of point cloud layer sample (#822) * initial commit of point cloud layer sample * Update ViewPointCloudDataOffline.qrc * Update ViewPointCloudDataOffline.cpp * Update main.cpp * adding the integrated mesh layer sample (#821) * adding the integrated mesh layer sample * Update AddIntegreatedMeshLayer.qrc * Integrated spelling. * Guil8553/at common 4495 override (#826) * add override, change Q_DECL_OVERRIDE to override for consistency, add QStringLiteral, clean up code for consistency * wip * wip * Fixed case sensitivity issue with sample on linux. (#827) * Ldanzinger/mspk (#824) MobileScenePackage sample * replaced c-style for loops to use ranged based loops where applicable * Reverting back to using an iterator type for QVariantMap. Added const to QString object. * adjusting formatting mistake * Reverting back to QVariantMap iterator. * Update sample to use MS since Epoch rather than seconds (#829) Update the search string to use MS since Epoch for the `updated` tags * Update LocalServerGeoprocessing.json * Update README.md * Update ChangeBasemap.qml (#832) * Backing out of toStdMap conversion. * Mfeigl/mobilemap unpack workflow (#833) * Open Mobile Map checks MMPK files whether they need to be unpacked before they can be loaded; and if so, unpacks them before loading. Some MMPK files contain data which need to be unpacked before they could be read and used. * Include missing header for iOS builds. * Get elevation at point (#835) Qt Get-Elevation-At-Point Sample. Qt/C++ and QML. 3d view over the Himalayas. User selects arbitrary point on the mountainside. Queries for elevation at that point. Displays elevation on screen. * Change the get elevation at point sample to be categorised under "Scenes" rather than "Analysis" (#836) * Ecmorris/create terrain surface from local raster (#837) Basic Sample demonstrating how to create a terrain elevation source from a local raster file. No interaction, just loads up a blank scene view and applies a raster elevation source. Raster elevation source is local data, and must be downloaded. QT/C++ and QML https://devtopia.esri.com/runtime/common-samples/issues/383 * GetElevation sample screenshots were not displaying in viewer. (#838) Fix to GetElevationatPoint sample screenshots not displaying in sample-viewer. * Mfeigl/add scene properties expressions (#839) * Created Qt C++/QML Scene Properties Expressions sample. * Updated the READMEs for Scene Properties Expressions for C++ and QML with proper screenshot names. (#840) * Changed display name of previous samples to be consistent with the others, (Starting with upper case, lower case subsequent words.) (#842) Changed the README of createTerrainSurfaceFromLocalRaster to actually reflect the C++ call made in the sample (append), as well as have bespoke wording for setting the QML property. * Emorris/create terrain surface from local tile package (#841) Create Surface from Local Tile Package sample. C++/Qt + QML * Fix blank sample: (#843) - update iconSource to icon.source - add icons to C++ sample * Mfeigl/choose camera controller (#845) * Created new sample: Choose camera controller. * Un-capitalising the titles of the Get elevation at point sample descriptions (#846) * Choose camera controller - responding to Verification comments. (#847) Mainly uncapitalized the title, as well as synchronized the loading sequence of the samples. * Choose camera controller has its menu title text adjusted to sample name. (#848) * Updated the Description images to the correct dimensions of 500x500 within the Choose Camera Control sample. (#850) * Fix the logic which had been inverted during a previous refactor (#851) * changing the ternary to better match the variable name * Update README.md * Minimum update time is ever 16ms. (#853) * Ldanzinger/fixes from cert (#854) * changing location of setSource * adding missing registration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High DPI flag enabled on all samples.