This repository has been archived by the owner on Jun 29, 2023. It is now read-only.
fix(action-bar): Sync expanded state with new children #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driskull
approved these changes
Jun 26, 2020
There was a problem hiding this comment.
This looks good @jgibson02! Thanks for the submission.
Do you think you could add an e2e test for this as well? Then we can make sure it doesn't stop working using the CI builds. 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #1023
Summary
Adds a MutationObserver to action-bar to watch for new children and enforces the current
expandedstate to them. Tried to replicate the usage of MutationObserver from other components.