Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

fix(pick-list): hide non-nested groups that do not match filter #1028

Merged
merged 1 commit into from
Jun 30, 2020
Merged

fix(pick-list): hide non-nested groups that do not match filter #1028

merged 1 commit into from
Jun 30, 2020

Conversation

jcfranco
Copy link
Member

Related Issue: #1026

Summary

This ensures that non-matching groups during filtering, whether nested (slot=parent-item) or not, are properly hidden.

cc @kevindoshier

@jcfranco jcfranco added the bug Something isn't working label Jun 30, 2020
@jcfranco jcfranco added this to the Ocean Princess milestone Jun 30, 2020
@jcfranco jcfranco requested a review from driskull June 30, 2020 14:59
@jcfranco jcfranco requested a review from a team as a code owner June 30, 2020 14:59
@jcfranco jcfranco self-assigned this Jun 30, 2020
driskull
driskull approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice rework :)

@jcfranco jcfranco merged commit c6bbe60 into master Jun 30, 2020
@jcfranco jcfranco deleted the jcfranco/1026-fix-non-nested-group-filtering branch June 30, 2020 15:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@driskull driskull driskull approved these changes

Assignees

@jcfranco jcfranco

Labels
bug Something isn't working
Projects
None yet
Milestone
Ocean Princess
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcfranco @driskull