feat(value-list): allow dragging items between lists #1059

jcfranco · 2020-08-25T15:57:38Z

Related Issue: #1056

Summary

Adds group prop to value-list to allow drag and drop items across lists with the same group (requires dragEnabled === true).

This also adds a e2e utility to help test DnD interactions and unskips previous DnD tests. 🛠️
I'll cherry-pick this over to calcite-components when merged. 😄

Since dragging between lists requires dragEnabled to be true, would it be better to rename the prop to dragGroup or something similar to indicate that they are linked?
I had not considered using the keyboard to move items across lists, is this something we should support? cc @asangma

driskull

Awesome 👏

jcfranco added 5 commits August 25, 2020 08:48

feat(value-list): allow dragging items between lists

e334061

tidy up value-list demos

5ed9639

add dnd test util

67c582f

unskip existing dnd tests

6cca7c9

add unit test for dragging between lists

0a4064d

jcfranco added the enhancement New feature request for an existing component label Aug 25, 2020

jcfranco added this to the Peppermint Butler milestone Aug 25, 2020

jcfranco requested review from driskull and asangma August 25, 2020 15:57

jcfranco requested a review from a team as a code owner August 25, 2020 15:57

jcfranco self-assigned this Aug 25, 2020

driskull approved these changes Aug 25, 2020

View reviewed changes

jcfranco merged commit 1c35a0d into master Aug 25, 2020

jcfranco deleted the jcfranco/1056-allow-dragging-items-between-value-lists branch August 25, 2020 17:31

jcfranco mentioned this pull request Aug 25, 2020

Enhancement: Support dragging items between Calcite Value Lists #1016

Closed