Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

feat(action): Add icon property to display calcite-icon. #837

Merged
merged 11 commits into from
Feb 27, 2020
Merged

feat(action): Add icon property to display calcite-icon. #837

merged 11 commits into from
Feb 27, 2020

Conversation

driskull
Copy link
Member

Related Issue: None

Summary

feat(action): Add icon property to display calcite-icon.

@driskull driskull added enhancement New feature request for an existing component 1 - assigned p - medium labels Feb 19, 2020
@driskull driskull added this to the Ice King milestone Feb 19, 2020
@driskull driskull requested a review from a team as a code owner February 19, 2020 21:40
@driskull driskull self-assigned this Feb 19, 2020
@driskull driskull removed the request for review from jcfranco February 19, 2020 22:11
asangma
asangma suggested changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@asangma asangma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing about the calcite-icon scale in relation to the calcite-action scale.

src/components/calcite-action/calcite-action.tsx Outdated Show resolved Hide resolved
jcfranco
jcfranco approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/components/calcite-action/calcite-action.e2e.ts Outdated Show resolved Hide resolved
src/components/calcite-action/calcite-action.tsx Outdated Show resolved Hide resolved
asangma
asangma approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@asangma asangma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I CON APPROVE IT.

@driskull driskull closed this Feb 27, 2020
@driskull driskull reopened this Feb 27, 2020
@driskull driskull merged commit 9de7724 into master Feb 27, 2020
@driskull driskull deleted the dris0000/calcite-action-icon-prop branch February 27, 2020 22:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jcfranco jcfranco jcfranco approved these changes

@asangma asangma asangma approved these changes

Assignees

@driskull driskull

Labels
1 - assigned enhancement New feature request for an existing component p - medium
Projects
None yet
Milestone
Ice King
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@driskull @jcfranco @asangma