This repository has been archived by the owner on Jun 29, 2023. It is now read-only.
fix(action): Support slotting icon after initialization #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfranco
reviewed
Apr 2, 2020
|
|
||
| buttonEl: HTMLButtonElement; | ||
|
|
||
| observer = new MutationObserver(() => this.setHasChildren()); |
There was a problem hiding this comment.
Would using forceUpdate after a mutation change help to simplify?
There was a problem hiding this comment.
I thought about that but wasn't sure if it was as efficient as using a state variable. Do you know?
There was a problem hiding this comment.
Haven't really played with it, but I'd think it's similar. Every time there's a mutation change you update state to rerender. Using forceUpdate seems like it would skip the setting state part. Worth testing.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: None
Summary
fix(action): Support slotting icon after initialization