Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

refactor!: Remove deprecated properties and slots from components #971

Merged
merged 1 commit into from
May 11, 2020

Conversation

driskull
Copy link
Member

@driskull driskull commented May 11, 2020

Related Issue: None

Summary

BREAKING CHANGE:

  • Removed deprecated 'text-*' properties from action-bar, action-pad, block, block-section, filter, flow-item, panel, tip-manager, and tip.
  • Removed deprecated 'layout' property from action-bar, action-pad, and shell-panel.
  • Removed deprecated 'compact' property from pick-list-item, pick-list, value-list, and value-list-item.
  • Removed deprecated tip-manager slot from shell.

@driskull driskull added 1 - assigned chore A minor task, usually housekeeping breaking This introduces a breaking change. labels May 11, 2020
@driskull driskull added this to the Marceline milestone May 11, 2020
@driskull driskull requested review from jcfranco and asangma May 11, 2020 17:53
@driskull driskull requested a review from a team as a code owner May 11, 2020 17:53
@driskull driskull self-assigned this May 11, 2020
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! Just had a few comments on the commit message:

  1. I think the commit header needs to be type(scope)!: ... to be compliant with conventional commits.
  2. Could you also add the BREAKING CHANGE: footer with context on these changes? They'll get pulled into the changelog.
  3. Should this commit type be refactor? I just tested and breaking changes do get pulled into the changelog regardless of type.
  4. I think (all) can be dropped.

@driskull driskull changed the title !fix(all): removed deprecated properties and slots refactor!: Remove deprecated properties and slots from components May 11, 2020
@driskull
Copy link
Member Author

driskull commented May 11, 2020

@jcfranco I can paste this in when I merge. Does it sound good?

BREAKING CHANGE:

- Removed deprecated 'text-*' properties from action-bar, action-pad, block, block-section, filter, flow-item, panel, tip-manager, and tip.
- Removed deprecated 'layout' property from action-bar, action-pad, and shell-panel.
- Removed deprecated 'compact' property from pick-list-item, pick-list, value-list, and value-list-item.
- Removed deprecated `tip-manager` slot from shell.

@jcfranco
Copy link
Member

Looks good! Maybe tip-manager should also be quoted similar to other props?

Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@driskull driskull merged commit a37633a into master May 11, 2020
@driskull driskull deleted the dris0000/v6 branch May 11, 2020 21:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 - assigned breaking This introduces a breaking change. chore A minor task, usually housekeeping
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants