Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No change event if input cleared after setting value programmatically with focus #4232

Closed
nwhittaker opened this issue Mar 14, 2022 · 4 comments
Closed

No change event if input cleared after setting value programmatically with focus #4232

nwhittaker opened this issue Mar 14, 2022 · 4 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Milestone
2023 February Pri...

Comments

@nwhittaker
Copy link
Contributor

nwhittaker commented Mar 14, 2022 •
edited

Actual Behavior

If an empty calcite-input element has focus and its value is set programmatically, it will not dispatch a calciteInputChange event if it's manually cleared and blurred.

Expected Behavior

A calciteInputChange event is dispatched because the value was changed due to a user interaction.

Reproduction Sample

https://ember-twiddle.com/84ec2591fdac5ae61ae10e6dc804d632/3e2cba5bcd55a0fb71c82258be68d252a4fea18e

Reproduction Steps

  1. Visit the sample and open the browser's dev tools console
  2. Click the "Seed value with focus shift" button
  3. After focus shifts to the input, clear the contents of the input, and then blur the input in some way
  4. Observe that "didChangeSeededInput" does not appear in the console indicating that the input's calciteInputChange handler was not run

Reproduction Version

1.0.0-next.415

Relevant Info

A follow-on to #4229.

Regression?

No response
@nwhittaker nwhittaker added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Mar 14, 2022
@benelan benelan removed the needs triage Planning workflow - pending design/dev review. label Mar 14, 2022
@benelan benelan added this to the Sprint 03/28 - 04/08 milestone Mar 14, 2022
@nwhittaker nwhittaker added the framework-ember Issues with Ember framework label Mar 15, 2022
@github-actions github-actions bot removed this from the Sprint 2022/08/22 - 2022/09/02 milestone Sep 5, 2022
@benelan benelan added ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. and removed ArcGIS Field Apps labels Jan 30, 2023
@jcfranco jcfranco self-assigned this Feb 7, 2023
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Feb 7, 2023
@jcfranco jcfranco mentioned this issue Feb 7, 2023
Merged
@jcfranco
Copy link
Member

jcfranco commented Feb 7, 2023

Non-Ember repro case: https://codepen.io/jcfranco/pen/yLqrPMp

@jcfranco jcfranco removed the framework-ember Issues with Ember framework label Feb 7, 2023
@geospatialem
Copy link
Member

Migrating to the upcoming February milestone for the fix to land later this month.

jcfranco added a commit that referenced this issue Feb 8, 2023
@jcfranco
fix(input, input-number, input-text): emit change value when clearing…
1802dc3 
… programmatically-set value (#6431)

**Related Issue:** #4232

## Summary

Updates value-setting code to treat programmatically-set values as the
last emitted one, which is used to determine whether to emit or not.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Feb 8, 2023
@github-actions github-actions bot assigned geospatialem and unassigned jcfranco Feb 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Feb 9, 2023
@geospatialem
Copy link
Member

Verified in 1.0.5

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Projects
None yet
Milestone
2023 February Priorities Patch (1.0.5...
Development

No branches or pull requests
4 participants
@jcfranco @nwhittaker @geospatialem @benelan