Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

combobox throws error when typing a custom value and then trying to open the menu #5109

Closed
jcfranco opened this issue Aug 5, 2022 · 3 comments
Closed

combobox throws error when typing a custom value and then trying to open the menu #5109

jcfranco opened this issue Aug 5, 2022 · 3 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. p - low Issue is non core or affecting less that 10% of people using the library
Milestone
2023 January Prio...

Comments

@jcfranco
Copy link
Member

jcfranco commented Aug 5, 2022

Actual Behavior

It seems the combobox expects custom values to be committed when opening the item menu, doing so throws the following:

p-40825758.entry.js:6 Uncaught TypeError: Cannot read properties of undefined (reading 'offsetHeight')
    at U.calculateSingleItemHeight (p-40825758.entry.js:6:11612)
    at U.scrollToActiveItem (p-40825758.entry.js:6:8224)
    at U.shiftActiveItemIndex (p-40825758.entry.js:6:14819)
    at U.keydownHandler (p-40825758.entry.js:6:3629)

Expected Behavior

At a minimum, no error should be thrown. What may need discussion is whether to allow the regular menu open experience and preserve the in-progress text if a selection is made.

Reproduction Sample

https://codepen.io/jcfranco/pen/abYGwWj?editors=1010

Reproduction Steps

  1. click on combobox input
  2. type extraneous value ("asdf"), w/o committing
  3. press down key

Reproduction Version

beta.90

Relevant Info

No response

Regression?

No response
@jcfranco jcfranco added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Aug 5, 2022
@geospatialem geospatialem added the p - low Issue is non core or affecting less that 10% of people using the library label Oct 12, 2022
@geospatialem geospatialem added this to the Back burner milestone Oct 12, 2022
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Oct 12, 2022
@driskull driskull self-assigned this Dec 16, 2022
@driskull driskull added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Dec 16, 2022
driskull added a commit that referenced this issue Dec 16, 2022
@driskull
fix(combobox): Fix error when typing a custom value and then trying t…
9841889 
…o open the menu. #5109
@driskull driskull mentioned this issue Dec 16, 2022
Merged
driskull added a commit that referenced this issue Dec 16, 2022
@driskull
fix(combobox): Fix error when typing a custom value (#6071)
246de97 
**Related Issue:** #5109

## Summary

fix(combobox): Fix error when typing a custom value and then trying to
open the menu. #5109
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Dec 16, 2022
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Jan 16, 2023
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. Stale Issues or pull requests that have not had recent activity. labels Jan 16, 2023
@geospatialem
Copy link
Member

Verified in beta.99.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
2023 January Priorities
Development

No branches or pull requests
4 participants
@jcfranco @driskull @alisonailea @geospatialem